Re: [PATCH 13/43] MAINTAINERS: fix git URL for EDAC

Fengguang Wu
2015-12-18T11:55:43Z

On Fri, Dec 18, 2015 at 12:41:55PM +0100, Borislav Petkov wrote:
> On Fri, Dec 18, 2015 at 06:57:33PM +0800, Fengguang Wu wrote:
> > That's the required format, documented earlier in MAINTAINERS:
> >
> > T: SCM tree type and location.
> > Type is one of: git, hg, quilt, stgit, topgit
> >
> > Which is followed all other places, eg.
> >
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> > T: git https://github.com/Xilinx/linux-xlnx.git
>
> Right, and IMO it should be done something like the diff below.
>
> The T: should contain the URL and if it is not clear from the URL
> type, the *type* of the repository should be appended and not some
> commands like "hg" or "quilt" or whatever. Especially if those commands
> don't necessarily tell you what the repo is unless you know what the
> executables' names mean.

That's all right for humans, however there are also in-tree and
out-of-tree scripts that parse the MAINTAINERS file and depend on
the current format.

So isn't it better to change the several lines for EDAC than to
convert hundreds of lines to the new format, plus converting the
related scripts?

Thanks,
Fengguang

> ---
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7271b6189ccf..09a9c76ff83e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -75,8 +75,8 @@ Descriptions of section entries:
> L: Mailing list that is relevant to this area
> W: Web-page with status/info
> Q: Patchwork web based patch tracking system site
> - T: SCM tree type and location.
> - Type is one of: git, hg, quilt, stgit, topgit
> + T: SCM tree type and location. If it is not clear from the SCM URL, the
> + SCM type is appended in brackets.
> S: Status, one of the following:
> Supported: Someone is actually paid to look after this.
> Maintained: Someone actually looks after it.
> @@ -1739,7 +1739,7 @@ M: Michal Simek <michal.simek@xilinx.com>
> R: Sören Brinkmann <soren.brinkmann@xilinx.com>
> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> W: http://wiki.xilinx.com
> -T: git https://github.com/Xilinx/linux-xlnx.git
> +T: https://github.com/Xilinx/linux-xlnx.git (git)
> S: Supported
> F: arch/arm/mach-zynq/
> F: drivers/cpuidle/cpuidle-zynq.c
> @@ -5604,7 +5604,7 @@ M: Gang Wei <gang.wei@intel.com>
> M: Shane Wang <shane.wang@intel.com>
> L: tboot-devel@lists.sourceforge.net
> W: http://tboot.sourceforge.net
> -T: hg http://tboot.hg.sourceforge.net:8000/hgroot/tboot/tboot
> +T: http://tboot.hg.sourceforge.net:8000/hgroot/tboot/tboot (mercurial)
> S: Supported
> F: Documentation/intel_txt.txt
> F: include/linux/tboot.h
>
> --
> Regards/Gruss,
> Boris.
>
> ECO tip #101: Trim your mails when you reply.