Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

Robert Jarzmik
2015-08-23T19:13:47Z

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
>
>> On 11 Aug 09:57 PM, Robert Jarzmik wrote:
>>> Add verbose debug for register accesses. This enables easier debugging
>>> by following where and how hardware is stimulated, and how it answers.
>>>
>>
>> I really don't see why we want this patch. It's probably an useful hack to
>> use in some cases, but can't see why we would want it in mainline.
>>
>> Feel free to prove me wrong.
> Why not.
>
> Imagine that there is a bug in the driver, such as the one with the status bits
> clearing. You can't reproduce it, and the person who has the hardware to
> reproduce it is not skilled enough to do any debug.
>
> What are the tools and what will you ask this tester to do in order to debug and
> solve his problem, as a good driver maintainer ?
>
> Amongst the drivers I wrote in the past, this approach was the most reliable to
> capture traces to debug remotely.

Ezequiel, do you agree with my point ?

Cheers.

--
Robert