Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

Robert Jarzmik
2015-12-19T12:19:30Z

Brian Norris <computersforpeace@gmail.com> writes:

> I don't have very strong opinions on this. It's kind of annoying to have
> this sort of stuff duplicated for every driver, if it's really needed.
> But I'll admit this kind of infrastructure is sometimes useful.
>
> Anecdote: I recently found the regmap trace event infrastructure pretty
> nice for debugging some other drivers. This would only require you to
> have tracing enabled, and then no recompiles are necessary at all. Just
> cmdline changes.
>
> So, I could go with this patch, if Robert still desires it. Or you could
> convert to using regmap for MMIO :)
I'm as you, I don't feel strong opinion about it, I'd like to have a debug
tracing tool, be that this patch or regmap MMIO.

If we all agree on a path I could even make the final patch, whichever solution
is chosen.

Cheers.

--
Robert