From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbbLSB7d (ORCPT ); Fri, 18 Dec 2015 20:59:33 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34839 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752523AbbLSB7a (ORCPT ); Fri, 18 Dec 2015 20:59:30 -0500 Date: Sat, 19 Dec 2015 07:29:26 +0530 From: Viresh Kumar To: SF Markus Elfring Cc: LKML , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] blackfin-cpufreq: Change return type of cpu_set_cclk() to that of clk_set_rate() Message-ID: <20151219015926.GJ3946@ubuntu> References: <5674598B.6020000@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5674598B.6020000@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-12-15, 20:07, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 18 Dec 2015 19:43:27 +0100 > > The return type "unsigned long" was used by the cpu_set_cclk() function > while the type "int" is provided by the clk_set_rate() function. > Let us make this usage consistent. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/cpufreq/blackfin-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/blackfin-cpufreq.c b/drivers/cpufreq/blackfin-cpufreq.c > index a9f8e5b..2a6f3ac 100644 > --- a/drivers/cpufreq/blackfin-cpufreq.c > +++ b/drivers/cpufreq/blackfin-cpufreq.c > @@ -112,7 +112,7 @@ static unsigned int bfin_getfreq_khz(unsigned int cpu) > } > > #ifdef CONFIG_BF60x > -unsigned long cpu_set_cclk(int cpu, unsigned long new) > +int cpu_set_cclk(int cpu, unsigned long new) > { > struct clk *clk; Acked-by: Viresh Kumar -- viresh