From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-scsi@vger.kernel.org,
Dick Kennedy <dick.kennedy@avagotech.com>,
"James E. J. Bottomley" <JBottomley@odin.com>,
James Smart <james.smart@avagotech.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] SCSI-lpfc: Use a signed return type for two functions
Date: Sat, 19 Dec 2015 23:17:07 +0300 [thread overview]
Message-ID: <20151219201707.GR5284@mwanda> (raw)
In-Reply-To: <5675A576.8020008@users.sourceforge.net>
It returns zero or negative error codes. The callers expect int. The
current code is harmless. It should return an int.
regards,
dan carpenter
prev parent reply other threads:[~2015-12-19 20:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 18:44 [PATCH] SCSI-lpfc: Use a signed return type for two functions SF Markus Elfring
2015-12-19 20:17 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151219201707.GR5284@mwanda \
--to=dan.carpenter@oracle.com \
--cc=JBottomley@odin.com \
--cc=dick.kennedy@avagotech.com \
--cc=elfring@users.sourceforge.net \
--cc=james.smart@avagotech.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox