From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965052AbbLSURk (ORCPT <rfc822;w@1wt.eu>);
	Sat, 19 Dec 2015 15:17:40 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:21915 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932724AbbLSURi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 19 Dec 2015 15:17:38 -0500
Date: Sat, 19 Dec 2015 23:17:07 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-scsi@vger.kernel.org, Dick Kennedy <dick.kennedy@avagotech.com>,
        "James E. J. Bottomley" <JBottomley@odin.com>,
        James Smart <james.smart@avagotech.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] SCSI-lpfc: Use a signed return type for two functions
Message-ID: <20151219201707.GR5284@mwanda>
References: <5675A576.8020008@users.sourceforge.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5675A576.8020008@users.sourceforge.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It returns zero or negative error codes.  The callers expect int.  The
current code is harmless.  It should return an int.

regards,
dan carpenter