From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbbLTAnJ (ORCPT ); Sat, 19 Dec 2015 19:43:09 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44973 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbbLTAnG (ORCPT ); Sat, 19 Dec 2015 19:43:06 -0500 Date: Sat, 19 Dec 2015 16:43:03 -0800 From: Greg KH To: Wills Wang Cc: jringle@gridpoint.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] sc16is7xx: fix incorrect register bits macro Message-ID: <20151220004303.GA18048@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 19, 2015 at 07:20:06PM +0800, Wills Wang wrote: > In datasheet, Modem Status Register MSR[4-5] reflect the modem pins > CTS/DSR/RI/CD signal state. > > Signed-off-by: Wills Wang > --- > drivers/tty/serial/sc16is7xx.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > index edb5305..9d18c24 100644 > --- a/drivers/tty/serial/sc16is7xx.c > +++ b/drivers/tty/serial/sc16is7xx.c > @@ -196,14 +196,14 @@ > * or (IO6) > * - only on 75x/76x > */ > -#define SC16IS7XX_MSR_CTS_BIT (1 << 0) /* CTS */ > -#define SC16IS7XX_MSR_DSR_BIT (1 << 1) /* DSR (IO4) > +#define SC16IS7XX_MSR_CTS_BIT (1 << 4) /* CTS */ > +#define SC16IS7XX_MSR_DSR_BIT (1 << 5) /* DSR (IO4) BIT(4) BIT(5)? Please do that at the same time... thanks, greg k-h