Re: [PATCH] sc16is7xx: fix incorrect register bits macro

Greg KH
2015-12-20T00:43:09Z

On Sat, Dec 19, 2015 at 07:20:06PM +0800, Wills Wang wrote:
> In datasheet, Modem Status Register MSR[4-5] reflect the modem pins
> CTS/DSR/RI/CD signal state.
>
> Signed-off-by: Wills Wang <wills.wang@live.com>
> ---
> drivers/tty/serial/sc16is7xx.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index edb5305..9d18c24 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -196,14 +196,14 @@
> * or (IO6)
> * - only on 75x/76x
> */
> -#define SC16IS7XX_MSR_CTS_BIT (1 << 0) /* CTS */
> -#define SC16IS7XX_MSR_DSR_BIT (1 << 1) /* DSR (IO4)
> +#define SC16IS7XX_MSR_CTS_BIT (1 << 4) /* CTS */
> +#define SC16IS7XX_MSR_DSR_BIT (1 << 5) /* DSR (IO4)

BIT(4) BIT(5)?

Please do that at the same time...

thanks,

greg k-h