public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Ingo Molnar <mingo@elte.hu>, Tony Luck <tony.luck@intel.com>,
	Ravi V Shankar <ravi.v.shankar@intel.com>,
	Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
	Vikas Shivappa <vikas.shivappa@linux.intel.com>
Subject: Re: [PATCH V16 11/11] x86,cgroup/intel_rdt : Add a cgroup interface to manage Intel cache allocation
Date: Sat, 19 Dec 2015 22:57:30 -0200	[thread overview]
Message-ID: <20151220005727.GB30427@amt.cnet> (raw)
In-Reply-To: <alpine.DEB.2.11.1512191139490.28591@nanos>

On Sat, Dec 19, 2015 at 11:42:57AM +0100, Thomas Gleixner wrote:
> On Thu, 17 Dec 2015, Fenghua Yu wrote:
> 
> > From: Fenghua Yu <fenghua.yu@intel.com>
> > 
> > From: Vikas Shivappa <vikas.shivappa@linux.intel.com>
> > 
> > Add a new cgroup 'intel_rdt' to manage cache allocation. Each cgroup
> > directory is associated with a class of service id(closid). To map a
> > task with closid during scheduling, this patch removes the closid field
> > from task_struct and uses the already existing 'cgroups' field in
> > task_struct.
> > 
> > The cgroup has a file 'l3_cbm' which represents the L3 cache capacity
> > bitmask(CBM). The CBM is global for the whole system currently. The
> > capacity bitmask needs to have only contiguous bits set and number of
> > bits that can be set is less than the max bits that can be set. The
> > tasks belonging to a cgroup get to fill in the L3 cache represented by
> > the capacity bitmask of the cgroup. For ex: if the max bits in the CBM
> > is 10 and the cache size is 10MB, each bit represents 1MB of cache
> > capacity.
> > 
> > Root cgroup always has all the bits set in the l3_cbm. User can create
> > more cgroups with mkdir syscall. By default the child cgroups inherit
> > the capacity bitmask(CBM) from parent. User can change the CBM specified
> > in hex for each cgroup. Each unique bitmask is associated with a class
> > of service ID and an -ENOSPC is returned once we run out of
> > closids.
> 
> This is still the original crap. No, we are not introducing this
> interface now just because we can. I explained in great length why
> this is completely useless and what we really need.
> 
> Thanks,
> 
> 	tglx

Can you make a summary of the points, and enumerate them, please.
(what are the problems of the current interface, and why such problems
are fixed in the new interface?).

Then someone can write it, integrate it, and everyone is happy.




  reply	other threads:[~2015-12-21 11:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 22:46 [PATCH V16 00/11] x86: Intel Cache Allocation Technology Support Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 01/11] x86/intel_cqm: Modify hot cpu notification handling Fenghua Yu
2015-12-18 21:33   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 02/11] x86/intel_rapl: " Fenghua Yu
2015-12-18 21:34   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 03/11] x86/intel_rdt: Cache Allocation documentation Fenghua Yu
2015-12-18 21:34   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 04/11] x86/intel_rdt: Add support for Cache Allocation detection Fenghua Yu
2015-12-18 21:34   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 05/11] x86/intel_rdt: Add Class of service management Fenghua Yu
2015-12-18 21:35   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 06/11] x86/intel_rdt: Add L3 cache capacity bitmask management Fenghua Yu
2015-12-18 21:35   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 07/11] x86/intel_rdt: Implement scheduling support for Intel RDT Fenghua Yu
2015-12-18 21:35   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 08/11] x86/intel_rdt: Hot cpu support for Cache Allocation Fenghua Yu
2015-12-18 21:36   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 09/11] x86/intel_rdt: Intel haswell Cache Allocation enumeration Fenghua Yu
2015-12-18 21:36   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 10/11] x86,cgroup/intel_rdt : Add intel_rdt cgroup documentation Fenghua Yu
2015-12-18 21:36   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-17 22:46 ` [PATCH V16 11/11] x86,cgroup/intel_rdt : Add a cgroup interface to manage Intel cache allocation Fenghua Yu
2015-12-18 21:37   ` [tip:x86/cache] " tip-bot for Fenghua Yu
2015-12-19 10:42   ` [PATCH V16 11/11] " Thomas Gleixner
2015-12-20  0:57     ` Marcelo Tosatti [this message]
2015-12-21 13:44       ` Thomas Gleixner
2015-12-21 15:48       ` Luiz Capitulino
2015-12-21 17:05         ` Marcelo Tosatti
2016-01-02 22:53           ` Richard Weinberger
2016-01-04 21:44             ` Yu, Fenghua
2016-01-04 21:47               ` Richard Weinberger
2015-12-18 17:45 ` [PATCH V16 00/11] x86: Intel Cache Allocation Technology Support Christoph Lameter
2015-12-18 20:49   ` Marcelo Tosatti
2015-12-21 12:53     ` Christoph Lameter
2015-12-21 15:55 ` Luiz Capitulino
2015-12-23 15:50 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151220005727.GB30427@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vikas.shivappa@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox