public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-can@vger.kernel.org, devicetree@vger.kernel.org,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	kernel@savoirfairelinux.com
Subject: Re: [PATCH 1/2] can: sja1000: add documentation for Technologic Systems version
Date: Sat, 19 Dec 2015 21:37:42 -0600	[thread overview]
Message-ID: <20151220033742.GA9883@rob-hp-laptop> (raw)
In-Reply-To: <1450469845-12900-1-git-send-email-damien.riegel@savoirfairelinux.com>

On Fri, Dec 18, 2015 at 03:17:24PM -0500, Damien Riegel wrote:
> This commit adds documentation for the Technologic Systems version of
> SJA1000. The difference with the NXP version is in the way the registers
> are accessed.
> 
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
>  Documentation/devicetree/bindings/net/can/sja1000.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/sja1000.txt b/Documentation/devicetree/bindings/net/can/sja1000.txt
> index b4a6d53..7a158d5 100644
> --- a/Documentation/devicetree/bindings/net/can/sja1000.txt
> +++ b/Documentation/devicetree/bindings/net/can/sja1000.txt
> @@ -2,7 +2,7 @@ Memory mapped SJA1000 CAN controller from NXP (formerly Philips)
>  
>  Required properties:
>  
> -- compatible : should be "nxp,sja1000".
> +- compatible : should be one of "nxp,sja1000", "technologic,sja1000".
>  
>  - reg : should specify the chip select, address offset and size required
>  	to map the registers of the SJA1000. The size is usually 0x80.
> @@ -14,6 +14,7 @@ Optional properties:
>  
>  - reg-io-width : Specify the size (in bytes) of the IO accesses that
>  	should be performed on the device.  Valid value is 1, 2 or 4.
> +	Must be set to 2 for technologic version.
>  	Default to 1 (8 bits).

Really, this should default to 2 for technologic version and not be 
required.

Rob

  parent reply	other threads:[~2015-12-20  3:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 20:17 [PATCH 1/2] can: sja1000: add documentation for Technologic Systems version Damien Riegel
2015-12-18 20:17 ` [PATCH 2/2] can: sja1000: of: add compatibility with " Damien Riegel
2015-12-18 20:41   ` Marc Kleine-Budde
2015-12-18 21:02     ` Damien Riegel
2015-12-18 21:05       ` Marc Kleine-Budde
2015-12-20  3:37 ` Rob Herring [this message]
2015-12-21 15:09   ` [PATCH 1/2] can: sja1000: add documentation for " Damien Riegel
2015-12-22 18:28     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151220033742.GA9883@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=damien.riegel@savoirfairelinux.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox