From: Darren Hart <dvhart@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Bhuvanesh_Surachari@mentor.com,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux@rasmusvillemoes.dk, viresh.kumar@linaro.org,
luto@amacapital.net, Sebastian Sewior <bigeasy@linutronix.de>,
mtk.manpages@gmail.com, LKML <linux-kernel@vger.kernel.org>,
Andy Lowe <Andy_Lowe@mentor.com>
Subject: Re: [PATCH] futex: Prevent pi_state from double freeing in case of error
Date: Sat, 19 Dec 2015 21:21:34 -0800 [thread overview]
Message-ID: <20151220052134.GI7244@malice.jf.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1512191615340.28591@nanos>
On Sat, Dec 19, 2015 at 07:24:38PM +0100, Thomas Gleixner wrote:
> - Why are the reviews so sloppy and useless?
>
> The one I'm answering to is just hillarious and the other one picks
> a random commit, claims that it inadvertantly introduced the issue
> and is done with it. Really helpful.
>
> Folks, this is not the way it works. It took me a couple of hours to
> get this analyzed properly, but I don't see that anyone involved in
> this thread has spent more than a few seconds on it.
>
> At least I found a real issue related to this refcount stuff, but I
> would have preferred that the people involved in this would have found
> it in the first place instead of providing half baken crap.
>
> Yours grumpy
>
> tglx
More care was clearly warranted on my part. I thought I saw the connection with
the previous commit I referenced (it wasn't random!), but clearly didn't dig
deep enough.
My apologies,
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-12-20 5:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 8:43 [PATCH] futex: Prevent pi_state from double freeing in case of error Bhuvanesh_Surachari
2015-12-18 14:55 ` Davidlohr Bueso
2015-12-19 18:24 ` Thomas Gleixner
2015-12-20 5:21 ` Darren Hart [this message]
2015-12-21 17:42 ` Davidlohr Bueso
2015-12-23 14:56 ` Bhuvanesh
2015-12-23 18:07 ` Thomas Gleixner
2015-12-18 23:08 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151220052134.GI7244@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=Andy_Lowe@mentor.com \
--cc=Bhuvanesh_Surachari@mentor.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox