From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933069AbbLTNvh (ORCPT <rfc822;w@1wt.eu>);
	Sun, 20 Dec 2015 08:51:37 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48610 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751087AbbLTNvg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 20 Dec 2015 08:51:36 -0500
Date: Sun, 20 Dec 2015 14:51:32 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint
 events
Message-ID: <20151220135132.GA17267@krava.local>
References: <1450193743-4409-1-git-send-email-namhyung@kernel.org>
 <1450193743-4409-6-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450193743-4409-6-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 16, 2015 at 12:35:38AM +0900, Namhyung Kim wrote:

SNIP

> +
> +	if (!len)
> +		len = hde_width(hde);
> +
> +	return len;
> +}
> +
> +static int __sort__hde_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> +			     struct hist_entry *he)
> +{
> +	struct hpp_dynamic_entry *hde;
> +	size_t len = fmt->user_len;
> +	struct trace_seq seq;
> +	int ret;
> +
> +	hde = container_of(fmt, struct hpp_dynamic_entry, hpp);
> +
> +	if (!len)
> +		len = hde_width(hde);
> +
> +	if (hists_to_evsel(he->hists) != hde->evsel)
> +		return scnprintf(hpp->buf, hpp->size, "%*.*s", len, len, "N/A");

hum, how can this happen? ... "hists_to_evsel(he->hists) != hde->evsel"

thanks,
jirka