From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750947AbbLTUJk (ORCPT ); Sun, 20 Dec 2015 15:09:40 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34881 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbbLTUJj (ORCPT ); Sun, 20 Dec 2015 15:09:39 -0500 Date: Sun, 20 Dec 2015 21:09:34 +0100 From: Richard Cochran To: SF Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable Message-ID: <20151220200934.GB2027@netboy> References: <56766488.9050402@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56766488.9050402@users.sourceforge.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 20, 2015 at 09:19:20AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 20 Dec 2015 09:09:34 +0100 > > The data type "int" was used by the variable "result" in the > function "posix_clock_poll" even though the type "uint" will usually > be needed for the return value from a call of the function which was > assigned to the pointer "poll" of the variable "clk". > Reuse the type from this poll call instead. > > This issue was detected by using the Coccinelle software. Coccinelle has pointed out a type mismatch. This fact may or may not indicate a real problem. You need to analyze code to see if there is a problem and then fix the problem. In this case, there is indeed a problem. However, just changing the type won't fix it. Thanks, Richard