From: Will Deacon <will.deacon@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Andrew Pinski <apinski@cavium.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM64: Fix compiling with GCC 6 and Atomics enabled
Date: Mon, 21 Dec 2015 12:51:30 +0000 [thread overview]
Message-ID: <20151221125130.GO23092@arm.com> (raw)
In-Reply-To: <CAKv+Gu_aUvckKpwWw+Xo5VkFEA8-uT9xU0-m5NgAzAc1d53uhQ@mail.gmail.com>
On Mon, Dec 21, 2015 at 01:46:22PM +0100, Ard Biesheuvel wrote:
> On 21 December 2015 at 13:38, Will Deacon <will.deacon@arm.com> wrote:
> > On Fri, Dec 18, 2015 at 08:17:35PM -0800, Andrew Pinski wrote:
> >> The problem here is that GCC 6 and above emits .arch now
> >> for each function so now the global .arch_extension has
> >> no effect. This fixes the problem by putting
> >> .arch_extension inside ARM64_LSE_ATOMIC_INSN so
> >> it is enabled for each place where LSE is used.
> >
> > Hmm, this is going to affect arch/arm/ much more heavily than arch/arm64.
> > .arch_extension is used for virt, mp and sec over there, and it may be
> > tricky to isolate the actual instruction usage (at least, virt looks
> > lost in kvm/arm.c).
> >
> > Why can't gas have an option to accept all instruction encodings that it
> > knows about, inspite of any .arch directives?
> >
>
> Modern GAS supports things like -march=armv7-a+mp+sec+virt, so it
> probably makes sense to pass that on the command line when building
> for v7 (or +sec only for v6) if the assembler is found to support it
> at build time.
Does that override a more restrictive .arch directive emitted by the
compiler?
Will
next prev parent reply other threads:[~2015-12-21 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 4:17 [PATCH] ARM64: Fix compiling with GCC 6 and Atomics enabled Andrew Pinski
2015-12-21 12:38 ` Will Deacon
2015-12-21 12:46 ` Ard Biesheuvel
2015-12-21 12:51 ` Will Deacon [this message]
2015-12-21 12:58 ` Ard Biesheuvel
2015-12-21 13:37 ` Will Deacon
2016-01-21 12:32 ` Vladimir Murzin
2016-01-21 14:32 ` Ard Biesheuvel
2015-12-21 13:03 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221125130.GO23092@arm.com \
--to=will.deacon@arm.com \
--cc=apinski@cavium.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).