Re: [PATCH v3] serial: 8250: add gpio support to exar

Andy Shevchenko
2015-12-22T09:58:21Z

On Tue, Dec 22, 2015 at 6:27 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Mon, Dec 21, 2015 at 08:28:51PM +0200, Andy Shevchenko wrote:
>> On Mon, Dec 21, 2015 at 5:19 PM, Sudip Mukherjee
>> <sudipm.mukherjee@gmail.com> wrote:
>>

>> There are at least two approaches:
>> - use 8250_pci, etc as a library (see example: 8250_mid.c)
>> - force 8250_pci to use external libraries in some cases (seems your approach)

Third one btw is to blow up the 8250_pci. (This actually was the main
reason why we chose separate driver approach in our case).

>> Of course better to gather maintainer's opinion first.
>
> Greg, can you please give some idea here about the best way to approach...
> I personally think, having it as a module with the minor changes that
> Alan and Andy has suggested is the best approach.

> The only downside is
> that the module gets loaded even if the device is not there.

How is that?

> But for
> arguments sake, the module will be enabled in the config only if someone
> is interested to build it. Everyone has the option to disable it if
> required.

--
With Best Regards,
Andy Shevchenko