Re: [PATCH v3] serial: 8250: add gpio support to exar

Sudip Mukherjee
2015-12-20T17:28:51Z

On Sun, Dec 20, 2015 at 04:43:53PM +0000, One Thousand Gnomes wrote:
> > v3: Alan commented on v2, few things like NULL check, name of the gpio chip,
> > moving some more code into the gpio code. He also commented on it being
> > a separate module, but since this will not be needed by someone who is not
> > using Exar chip, and even those who are using, some of them may not need it.
> > This is optional for only those who wants to use the gpio capability of that
> > chip. So kept it as a separate module. Waiting for your comments on that.
>
> That doesn't work because you reference the methods in it so it will
> always be dragged in. You would have to make the exar driver an MFD that
> provided a serial and a gpio binding to fix that up I think, or instead
> of having the serial driver call into your gpio driver (thus forcing the
> module into memory) you would have the serial driver create a platform
> device or similar that the GPIO device bound to.

So then should I rewrite it as MFD or should it be like the way you
suggested in the other mail to have it as bool in the Kconfig and combine
the file with 8250_pci.c when the symbol is selected?

regards
sudip