From: Olof Johansson <olof@lixom.net>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: arnd@arndb.de, fengguang.wu@intel.com, arm@kernel.org,
linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] iio: exynos-adc: fix irqf_oneshot.cocci warnings
Date: Mon, 21 Dec 2015 21:09:25 -0800 [thread overview]
Message-ID: <20151222050925.GL30172@localhost> (raw)
In-Reply-To: <20151202084310.GA4665@debian-vm>
On Wed, Dec 02, 2015 at 09:43:10AM +0100, Valentin Rothberg wrote:
> Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
> threaded IRQs without a primary handler need to be requested with
> IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---
>
> The patch looks fine to me: bad things can happen when interrupts are
> acked before the handler ran.
Hi,
Applied. Thanks.
-Olof
prev parent reply other threads:[~2015-12-22 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 8:43 [PATCH] iio: exynos-adc: fix irqf_oneshot.cocci warnings Valentin Rothberg
2015-12-22 5:09 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222050925.GL30172@localhost \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).