From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754194AbbLVKJQ (ORCPT ); Tue, 22 Dec 2015 05:09:16 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:36839 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbbLVKJN (ORCPT ); Tue, 22 Dec 2015 05:09:13 -0500 Date: Tue, 22 Dec 2015 15:38:59 +0530 From: Sudip Mukherjee To: Andy Shevchenko Cc: Greg Kroah-Hartman , One Thousand Gnomes , Jiri Slaby , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" Subject: Re: [PATCH v3] serial: 8250: add gpio support to exar Message-ID: <20151222100859.GA24622@sudip-pc> References: <1450617891-26167-1-git-send-email-sudipm.mukherjee@gmail.com> <20151220164353.6ef29f77@lxorguk.ukuu.org.uk> <20151220172841.GB8471@sudip-laptop> <20151220174208.1447d2f3@lxorguk.ukuu.org.uk> <20151221151904.GA23780@sudip-pc> <20151222042707.GA3250@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 22, 2015 at 11:58:17AM +0200, Andy Shevchenko wrote: > On Tue, Dec 22, 2015 at 6:27 AM, Sudip Mukherjee > wrote: > > On Mon, Dec 21, 2015 at 08:28:51PM +0200, Andy Shevchenko wrote: > >> On Mon, Dec 21, 2015 at 5:19 PM, Sudip Mukherjee > >> wrote: > >> > > >> There are at least two approaches: > >> - use 8250_pci, etc as a library (see example: 8250_mid.c) > >> - force 8250_pci to use external libraries in some cases (seems your approach) > > Third one btw is to blow up the 8250_pci. (This actually was the main > reason why we chose separate driver approach in our case). > > >> Of course better to gather maintainer's opinion first. > > > > Greg, can you please give some idea here about the best way to approach... > > I personally think, having it as a module with the minor changes that > > Alan and Andy has suggested is the best approach. > > > The only downside is > > that the module gets loaded even if the device is not there. > > How is that? Alan explained that in https://lkml.org/lkml/2015/12/20/103 Quoting from his mail "you reference the methods in it so it will always be dragged in". And I wanted to verify that so I tested today morning after removing the card from my local system and after booting I saw having 8250_gpi loaded. regards sudip