From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932842AbbLVOsZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Dec 2015 09:48:25 -0500
Received: from mail-pf0-f171.google.com ([209.85.192.171]:35431 "EHLO
	mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932243AbbLVOsY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Dec 2015 09:48:24 -0500
Date: Tue, 22 Dec 2015 23:47:38 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 07/10] perf tools: Add 'trace' sort key
Message-ID: <20151222144738.GA4508@danjae.kornet>
References: <1450708013-7805-1-git-send-email-namhyung@kernel.org>
 <1450708013-7805-8-git-send-email-namhyung@kernel.org>
 <20151222072203.GC13404@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151222072203.GC13404@krava.brq.redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jiri,

On Tue, Dec 22, 2015 at 08:22:03AM +0100, Jiri Olsa wrote:
> On Mon, Dec 21, 2015 at 11:26:50PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index e28d26d0e73c..50a6b35a2fee 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> > @@ -445,6 +445,65 @@ struct sort_entry sort_socket = {
> >  	.se_width_idx	= HISTC_SOCKET,
> >  };
> >  
> > +/* --sort trace */
> > +
> > +static char *get_trace_output(struct hist_entry *he)
> > +{
> > +	struct trace_seq seq;
> > +	struct perf_evsel *evsel;
> > +	struct pevent_record rec = {
> > +		.data = he->raw_data,
> > +		.size = he->raw_size,
> > +	};
> > +
> > +	evsel = hists_to_evsel(he->hists);
> > +
> > +	trace_seq_init(&seq);
> > +	pevent_event_info(&seq, evsel->tp_format, &rec);
> > +	return seq.buffer;
> > +}
> 
> this function could be global and used in previous patch
> in update_dynamic_len for trace_output?

OK.

> 
> hum, one's using evsel->tp_format and the other field->event,
> I can't recall if both point to the same stuff..

AFAIK they should point to the same.

Thanks,
Namhyung