From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: robh+dt@kernel.org, heiko@sntech.de, arnd@arndb.de,
john.stultz@linaro.org, sjg@chromium.org, treding@nvidia.com,
galak@codeaurora.org, ijc+devicetree@hellion.org.uk,
wxt@rock-chips.com, catalin.marinas@arm.com, olof@lixom.net,
geert+renesas@glider.be, linux-rockchip@lists.infradead.org,
dbaryshkov@gmail.com, sre@kernel.org, jun.nie@linaro.org,
pawel.moll@arm.com, will.deacon@arm.com,
akpm@linux-foundation.org, devicetree@vger.kernel.org,
linux@arm.linux.org.uk, gregkh@linuxfoundation.org,
joel@jms.id.au, linux-arm-kernel@lists.infradead.org,
lorenzo.pieralisi@arm.com, khilman@linaro.org,
moritz.fischer@ettus.com, linux-kernel@vger.kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH v1 0/6] misc: add reboot mode driver
Date: Tue, 22 Dec 2015 17:47:42 +0100 [thread overview]
Message-ID: <20151222164742.GA8623@piout.net> (raw)
In-Reply-To: <1450774949-23901-1-git-send-email-andy.yan@rock-chips.com>
Hi,
On 22/12/2015 at 17:02:29 +0800, Andy Yan wrote :
>
> This driver parse the reboot commands like "reboot loader"
> and "reboot recovery" to get a boot mode described in the
> device tree , then call the vendor specific write interfae
> to store the boot mode in some place like special register
> or sram , which can be read by the bootloader after system
> reboot.
>
> This is commonly done on Android based devices, in order to
> reboot the device into fastboot or recovery mode.
>
> Before this patch , I have try some hack on[0], and then found
> John Stultz also doing the same work[1].
>
> As John is busy these days, I go on with this work.
>
> [0]https://patchwork.kernel.org/patch/7647751/
> [1]https://patchwork.kernel.org/patch/7802391/
>
> Changes in v1:
> - fix the embarrassed compile warning
> - correct the maskrom magic number
> - check for the normal reboot
> - correct the maskrom magic number
> - use macro defined in rockchip_boot-mode.h for reboot-mode DT node
>
> Andy Yan (6):
> dt-bindings: misc: add document for reboot-mode driver
> dt-bindings: soc: add document for rockchip reboot-mode driver
> misc: add reboot mode driver
> soc: rockchip: add reboot mode driver
> ARM: dts: rockchip: add reboot-mode node
> ARM64: dts: rockchip: add reboot-mode node
>
This seems nice and useful, some further ideas:
> .../devicetree/bindings/misc/reboot-mode.txt | 41 +++++++++
> .../bindings/soc/rockchip/rockchip,reboot-mode.txt | 39 +++++++++
> arch/arm/boot/dts/rk3288.dtsi | 26 ++++++
> arch/arm/boot/dts/rk3xxx.dtsi | 26 ++++++
> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 26 ++++++
> drivers/misc/Kconfig | 7 ++
> drivers/misc/Makefile | 1 +
> drivers/misc/reboot_mode.c | 96 ++++++++++++++++++++++
I think this actually belongs to drivers/power/reset/ instead of misc
> drivers/soc/rockchip/Kconfig | 9 ++
> drivers/soc/rockchip/Makefile | 1 +
> drivers/soc/rockchip/reboot.c | 68 +++++++++++++++
And maybe that part could be made generic instead of rockchip specific.
It simply uses a regmap to do the accesses, I guess a lot of other
platforms will do that. We have syscon-reboot and syscon-poweroff for example.
I think then we can extend the "framework" by having generic drivers to
store the value in eeprom or nvram for example.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-22 16:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 9:02 [PATCH v1 0/6] misc: add reboot mode driver Andy Yan
2015-12-22 9:05 ` [PATCH v1 1/6] dt-bindings: misc: add document for reboot-mode driver Andy Yan
2015-12-23 0:32 ` Rob Herring
2015-12-23 8:37 ` Moritz Fischer
2015-12-23 9:01 ` Andy Yan
2015-12-22 9:08 ` [PATCH v1 2/6] dt-bindings: soc: add document for rockchip " Andy Yan
2015-12-22 9:10 ` [PATCH v1 3/6] misc: add reboot mode driver Andy Yan
2015-12-22 9:13 ` [PATCH v1 4/6] soc: rockchip: " Andy Yan
2015-12-22 9:16 ` [PATCH v1 5/6] ARM: dts: rockchip: add reboot-mode node Andy Yan
2015-12-22 11:23 ` Heiko Stübner
2015-12-22 9:19 ` [PATCH v1 6/6] ARM64: " Andy Yan
2015-12-22 16:47 ` Alexandre Belloni [this message]
2015-12-23 9:31 ` [PATCH v1 0/6] misc: add reboot mode driver Andy Yan
2015-12-28 15:28 ` Arnd Bergmann
2015-12-28 15:56 ` Heiko Stübner
2015-12-28 16:09 ` Arnd Bergmann
2015-12-29 7:55 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222164742.GA8623@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=akpm@linux-foundation.org \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joel@jms.id.au \
--cc=john.stultz@linaro.org \
--cc=jun.nie@linaro.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sjg@chromium.org \
--cc=sre@kernel.org \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox