From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754443AbbLVTjm (ORCPT ); Tue, 22 Dec 2015 14:39:42 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34346 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754286AbbLVTj3 (ORCPT ); Tue, 22 Dec 2015 14:39:29 -0500 Date: Tue, 22 Dec 2015 11:22:52 -0800 From: Olof Johansson To: Masahiro Yamada Cc: arm@kernel.org, Mark Rutland , arnd@arndb.de, devicetree@vger.kernel.org, Kumar Gala , linux-kernel@vger.kernel.org, Ian Campbell , Rob Herring , Pawel Moll , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5] bus: uniphier-system-bus: add UniPhier System Bus driver Message-ID: <20151222192252.GO30172@localhost> References: <1449643979-27329-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449643979-27329-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 09, 2015 at 03:52:59PM +0900, Masahiro Yamada wrote: > The UniPhier System Bus is an external bus that connects on-board > devices to the UniPhier SoC. Each bank (chip select) is dynamically > mapped to the CPU-viewed address base via the bus controller. The > bus controller must be configured before any access to the bus. > > This driver parses the "ranges" property of the System Bus node and > initialized the bus controller. After the bus becomes ready, devices > below it are populated. > > Note: > Each bank can be mapped anywhere in the supported address space; > there is nothing preventing us from assigning bank 0 on 0x42000000, > 0x43000000, or anywhere as long as such region is not used by others. > So, the "ranges" is just one possible software configuration, which > does not seem to fit in device tree because device tree is a hardware > description language. However, of_translate_address() requires > "ranges" in every bus node between CPUs and device mapped on the CPU > address space. In other words, "ranges" properties must be statically > defined in device tree. After some discussion, I decided the dynamic > address reassignment by the driver is too bothersome. Instead, the > device tree should provide a reasonable translation setup that the OS > can rely on. > > Signed-off-by: Masahiro Yamada > Acked-by: Rob Herring > Acked-by: Arnd Bergmann Thanks, applied to next/drivers. -Olof