From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the rtc tree
Date: Tue, 22 Dec 2015 20:27:51 +0100 [thread overview]
Message-ID: <20151222192751.GG8623@piout.net> (raw)
In-Reply-To: <20151218164341.GB3541@piout.net>
Hi Sasha,
On 18/12/2015 at 17:43:41 +0100, Alexandre Belloni wrote :
> > > Sasha, I think I prefer having 32 bit platforms fail on the 21st of
> > > January 11761191 rather than adding more uses of do_div in the function.
> > > I'll have a look at the performance impact on 32 bit platforms.
> >
> > I'm really fine with just adding a WARN_ON() and aborting if it's the year
> > 11761191 :)
> >
>
> One simple way to solve it for 64bit platforms is to define days as
> unsigned long. Maybe throw a comment that it will fail for 32bit
> platforms in January 11761191 ;).
>
I did that:
http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=0d3da1806b985f1100615c2c09033b404941b63e
Unless you disagree, that is what I'm planning to send to Linus.
I wish you a happy end of year.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-22 19:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 5:03 linux-next: build failure after merge of the rtc tree Stephen Rothwell
2015-12-17 11:21 ` Alexandre Belloni
2015-12-18 15:30 ` Sasha Levin
2015-12-18 16:43 ` Alexandre Belloni
2015-12-22 19:27 ` Alexandre Belloni [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-08 6:41 Stephen Rothwell
2016-11-08 22:21 ` Alexandre Belloni
2017-04-10 6:04 Stephen Rothwell
2017-04-10 7:45 ` Hans de Goede
2017-04-11 0:22 ` Stephen Rothwell
2017-04-11 5:55 ` Alexandre Belloni
2017-04-11 7:52 ` Stephen Rothwell
2017-04-14 10:09 ` Alexandre Belloni
2017-04-14 16:33 ` Stephen Rothwell
2017-05-31 4:33 Stephen Rothwell
2017-05-31 5:45 ` Heiner Kallweit
2017-05-31 7:19 ` Alexandre Belloni
2019-02-08 5:55 Stephen Rothwell
2019-02-11 5:24 Stephen Rothwell
2019-10-04 4:37 Stephen Rothwell
2020-03-16 5:15 Stephen Rothwell
2020-03-16 6:58 ` Ran Bi
2020-03-16 10:31 ` Alexandre Belloni
2021-08-10 5:54 Stephen Rothwell
2021-09-27 3:10 Stephen Rothwell
2021-09-27 7:16 ` Romain Perier
2023-10-16 4:15 Stephen Rothwell
2023-10-16 4:34 ` Alexandre Belloni
2023-10-16 7:11 ` Uwe Kleine-König
2024-11-13 5:23 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222192751.GG8623@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox