From: Matthew Wilcox <willy@linux.intel.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: arrange header files
Date: Wed, 23 Dec 2015 09:35:59 -0500 [thread overview]
Message-ID: <20151223143559.GG2457@linux.intel.com> (raw)
In-Reply-To: <1450877827-19983-1-git-send-email-sudipm.mukherjee@gmail.com>
On Wed, Dec 23, 2015 at 07:07:07PM +0530, Sudip Mukherjee wrote:
> We are having build failure with sparc allmodconfig with the error:
> drivers/nvme/host/pci.c:15:0:
> include/linux/aer.h: In function 'pci_enable_pcie_error_reporting':
> include/linux/aer.h:49:10: error: 'EINVAL' undeclared (first use in this function)
>
> The file aer.h is using the error values but they are defined in
> errno.h. So if we keep aer.h at the top of header file then we do not
> have any definition of EINVAL.
aer.h should be including errno.h.
prev parent reply other threads:[~2015-12-23 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 13:37 [PATCH] nvme: arrange header files Sudip Mukherjee
2015-12-23 14:35 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223143559.GG2457@linux.intel.com \
--to=willy@linux.intel.com \
--cc=axboe@fb.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox