From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755962AbbLWOgV (ORCPT ); Wed, 23 Dec 2015 09:36:21 -0500 Received: from mga01.intel.com ([192.55.52.88]:39634 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754362AbbLWOgU (ORCPT ); Wed, 23 Dec 2015 09:36:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,469,1444719600"; d="scan'208";a="713517319" Date: Wed, 23 Dec 2015 09:35:59 -0500 From: Matthew Wilcox To: Sudip Mukherjee Cc: Keith Busch , Jens Axboe , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH] nvme: arrange header files Message-ID: <20151223143559.GG2457@linux.intel.com> References: <1450877827-19983-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450877827-19983-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2015 at 07:07:07PM +0530, Sudip Mukherjee wrote: > We are having build failure with sparc allmodconfig with the error: > drivers/nvme/host/pci.c:15:0: > include/linux/aer.h: In function 'pci_enable_pcie_error_reporting': > include/linux/aer.h:49:10: error: 'EINVAL' undeclared (first use in this function) > > The file aer.h is using the error values but they are defined in > errno.h. So if we keep aer.h at the top of header file then we do not > have any definition of EINVAL. aer.h should be including errno.h.