public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Remi Pommarel <repk@triplefau.lt>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Eric Anholt <eric@anholt.net>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] Add PWM clock support for bcm2835
Date: Wed, 23 Dec 2015 19:57:04 +0100	[thread overview]
Message-ID: <20151223185704.GJ453@cruxbox> (raw)
In-Reply-To: <1449418969-5565-1-git-send-email-repk@triplefau.lt>

On Sun, Dec 06, 2015 at 05:22:45PM +0100, Remi Pommarel wrote:
> Hi,
> 
> This patchset adds support for pwm clock. At boot, this clock does not have a
> default parent nor a default rate set. Thus we should be able to change its
> parent to get this clock working. The current clock implementation is using a
> mux to select the parent, but these clocks need to add a password (0x5a) in
> higher register bits when changing parent. So a generic mux cannot be used
> here.
> 
> The two first patches fix the clock parent selection, while the last ones are
> actually adding the pwm clock registration.
> 
> Changes since v1:
> 	- determine_rate now based its parent selection upon divided rate
> 	  instead of the parent one
> 	- bcm2835_clock_choose_div has been modified to produce an avarage rate
> 	  lower or equal to the requested one
> 	- devicetree modifications have removed to be send in another patch
> 
> Changes since v2:
> 	- Remove useless variable and include
> 	- Make bcm2835_clock_choose_div() divisor round up ability optional
> 	- Set rate in bcm2835_determine_rate()
> 	- Add device tree modification in a separate patch
> 
> 
> Remi Pommarel (4):
>   clk: bcm2835: add a round up ability to the clock divisor
>   clk: bcm2835: Support for clock parent selection
>   clk: bcm2835: Add PWM clock support
>   clk: bcm2835: Add PWM clock support to the device tree
> 
>  arch/arm/boot/dts/bcm2835-rpi.dtsi  |   4 +
>  arch/arm/boot/dts/bcm2835.dtsi      |   9 +++
>  drivers/clk/bcm/clk-bcm2835.c       | 155 +++++++++++++++++++++++-------------
>  include/dt-bindings/clock/bcm2835.h |   3 +-
>  4 files changed, 116 insertions(+), 55 deletions(-)
> 

Gently ping.

Patches 0 to 3 are reviewed by Eric, and can eventually be pushed on clk
tree.

Patch 4 has been sent on devicetree mailinglist for review
(http://www.spinics.net/lists/devicetree/msg108070.html), waiting for
previous patches to be pushed.

Thanks

-- 
Remi

  parent reply	other threads:[~2015-12-23 18:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 16:22 [PATCH v3 0/4] Add PWM clock support for bcm2835 Remi Pommarel
2015-12-06 16:22 ` [PATCH v3 1/4] clk: bcm2835: add a round up ability to the clock divisor Remi Pommarel
2015-12-08  1:28   ` Eric Anholt
2016-01-10 16:27   ` Martin Sperl
2015-12-06 16:22 ` [PATCH v3 2/4] clk: bcm2835: Support for clock parent selection Remi Pommarel
2015-12-08  1:32   ` Eric Anholt
2015-12-06 16:22 ` [PATCH v3 3/4] clk: bcm2835: Add PWM clock support Remi Pommarel
2015-12-06 16:22 ` [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree Remi Pommarel
2015-12-06 21:16   ` Stefan Wahren
2015-12-07 18:17     ` Remi Pommarel
2015-12-07 18:42       ` Stefan Wahren
2015-12-08  4:09         ` Eric Anholt
2015-12-16  7:57           ` Remi Pommarel
2015-12-16 20:05             ` Eric Anholt
2015-12-23 18:57 ` Remi Pommarel [this message]
2015-12-25  5:06   ` [PATCH v3 0/4] Add PWM clock support for bcm2835 Michael Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151223185704.GJ453@cruxbox \
    --to=repk@triplefau.lt \
    --cc=eric@anholt.net \
    --cc=lee@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox