From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jerry Snitselaar <jsnitsel@redhat.com>
Subject: [for-next][PATCH 06/13] tracing: Use seq_buf_used() in seq_buf_to_user() instead of len
Date: Thu, 24 Dec 2015 09:27:58 -0500 [thread overview]
Message-ID: <20151224142900.422871356@goodmis.org> (raw)
In-Reply-To: 20151224142752.534947674@goodmis.org
[-- Attachment #1: 0006-tracing-Use-seq_buf_used-in-seq_buf_to_user-instead-.patch --]
[-- Type: text/plain, Size: 1173 bytes --]
From: Jerry Snitselaar <jsnitsel@redhat.com>
commit 5ac48378414d ("tracing: Use trace_seq_used() and seq_buf_used()
instead of len") changed the tracing code to use trace_seq_used() and
seq_buf_used() instead of using the seq_buf len directly to avoid
overflow issues, but missed a spot in seq_buf_to_user() that makes use
of s->len.
Cleaned up the code a bit as well per suggestion of Steve Rostedt.
Link: http://lkml.kernel.org/r/1447703848-2951-1-git-send-email-jsnitsel@redhat.com
Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
lib/seq_buf.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/seq_buf.c b/lib/seq_buf.c
index 5c94e1012a91..cb18469e1f49 100644
--- a/lib/seq_buf.c
+++ b/lib/seq_buf.c
@@ -306,10 +306,12 @@ int seq_buf_to_user(struct seq_buf *s, char __user *ubuf, int cnt)
if (!cnt)
return 0;
- if (s->len <= s->readpos)
+ len = seq_buf_used(s);
+
+ if (len <= s->readpos)
return -EBUSY;
- len = seq_buf_used(s) - s->readpos;
+ len -= s->readpos;
if (cnt > len)
cnt = len;
ret = copy_to_user(ubuf, s->buffer + s->readpos, cnt);
--
2.6.2
next prev parent reply other threads:[~2015-12-24 14:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 14:27 [for-next][PATCH 00/13] tracing: More updates for 4.5 Steven Rostedt
2015-12-24 14:27 ` [for-next][PATCH 01/13] ftrace: Fix a typo in comment Steven Rostedt
2015-12-24 14:27 ` [for-next][PATCH 02/13] ftrace: Fix output of enabled_functions for showing tramp Steven Rostedt
2015-12-24 14:27 ` [for-next][PATCH 03/13] ftrace: Remove use of control list and ops Steven Rostedt
2015-12-24 14:27 ` [for-next][PATCH 04/13] ftrace: Have ftrace_ops_get_func() handle RCU and PER_CPU flags too Steven Rostedt
2015-12-24 14:27 ` [for-next][PATCH 05/13] bpf: Constify bpf_verifier_ops structure Steven Rostedt
2015-12-24 14:27 ` Steven Rostedt [this message]
2015-12-24 14:27 ` [for-next][PATCH 07/13] tracing: Introduce TRACE_EVENT_FN_COND macro Steven Rostedt
2015-12-24 14:28 ` [for-next][PATCH 08/13] ftrace: Join functions ftrace_module_init() and ftrace_init_module() Steven Rostedt
2015-12-24 14:28 ` [for-next][PATCH 09/13] ftrace: Clean up ftrace_module_init() code Steven Rostedt
2015-12-24 14:28 ` [for-next][PATCH 10/13] ia64: ftrace: Fix the comments for ftrace_modify_code() Steven Rostedt
2015-12-24 14:28 ` [for-next][PATCH 11/13] sh: " Steven Rostedt
2015-12-24 14:28 ` [for-next][PATCH 12/13] metag: ftrace: Fix the comments for ftrace_modify_code Steven Rostedt
2015-12-24 14:28 ` [for-next][PATCH 13/13] tracing: Fix comment to use tracing_on over tracing_enable Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151224142900.422871356@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=jsnitsel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox