* [PATCH] Fix documentation for adp1653 DT
@ 2015-12-25 23:37 Pali Rohár
2015-12-26 18:34 ` Pavel Machek
2016-01-06 23:23 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Pali Rohár @ 2015-12-25 23:37 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Pavel Machek, Mauro Carvalho Chehab, Sakari Ailus
Cc: devicetree, linux-kernel, Pali Rohár
Property names do not match real names needed by driver itself.
This patch fix this problem.
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
.../devicetree/bindings/media/i2c/adp1653.txt | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/adp1653.txt b/Documentation/devicetree/bindings/media/i2c/adp1653.txt
index 5ce66f2..4cce0de 100644
--- a/Documentation/devicetree/bindings/media/i2c/adp1653.txt
+++ b/Documentation/devicetree/bindings/media/i2c/adp1653.txt
@@ -12,12 +12,13 @@ There are two LED outputs available - flash and indicator. One LED is
represented by one child node, nodes need to be named "flash" and "indicator".
Required properties of the LED child node:
-- max-microamp : see Documentation/devicetree/bindings/leds/common.txt
+- led-max-microamp : see Documentation/devicetree/bindings/leds/common.txt
Required properties of the flash LED child node:
- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt
- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt
+- led-max-microamp : see Documentation/devicetree/bindings/leds/common.txt
Example:
@@ -29,9 +30,9 @@ Example:
flash {
flash-timeout-us = <500000>;
flash-max-microamp = <320000>;
- max-microamp = <50000>;
+ led-max-microamp = <50000>;
};
indicator {
- max-microamp = <17500>;
+ led-max-microamp = <17500>;
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix documentation for adp1653 DT
2015-12-25 23:37 [PATCH] Fix documentation for adp1653 DT Pali Rohár
@ 2015-12-26 18:34 ` Pavel Machek
2016-01-06 23:23 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2015-12-26 18:34 UTC (permalink / raw)
To: Pali Rohár
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Mauro Carvalho Chehab, Sakari Ailus, devicetree, linux-kernel
On Sat 2015-12-26 00:37:16, Pali Rohár wrote:
> Property names do not match real names needed by driver itself.
> This patch fix this problem.
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Now... if someone could convert adp1653 to the LED subsystem so this
is testable from the shell...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix documentation for adp1653 DT
2015-12-25 23:37 [PATCH] Fix documentation for adp1653 DT Pali Rohár
2015-12-26 18:34 ` Pavel Machek
@ 2016-01-06 23:23 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2016-01-06 23:23 UTC (permalink / raw)
To: Pali Rohár
Cc: Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Pavel Machek,
Mauro Carvalho Chehab, Sakari Ailus, devicetree, linux-kernel
On Sat, Dec 26, 2015 at 12:37:16AM +0100, Pali Rohár wrote:
> Property names do not match real names needed by driver itself.
> This patch fix this problem.
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Applied, thanks.
Rob
> ---
> .../devicetree/bindings/media/i2c/adp1653.txt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/adp1653.txt b/Documentation/devicetree/bindings/media/i2c/adp1653.txt
> index 5ce66f2..4cce0de 100644
> --- a/Documentation/devicetree/bindings/media/i2c/adp1653.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/adp1653.txt
> @@ -12,12 +12,13 @@ There are two LED outputs available - flash and indicator. One LED is
> represented by one child node, nodes need to be named "flash" and "indicator".
>
> Required properties of the LED child node:
> -- max-microamp : see Documentation/devicetree/bindings/leds/common.txt
> +- led-max-microamp : see Documentation/devicetree/bindings/leds/common.txt
>
> Required properties of the flash LED child node:
>
> - flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt
> - flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt
> +- led-max-microamp : see Documentation/devicetree/bindings/leds/common.txt
>
> Example:
>
> @@ -29,9 +30,9 @@ Example:
> flash {
> flash-timeout-us = <500000>;
> flash-max-microamp = <320000>;
> - max-microamp = <50000>;
> + led-max-microamp = <50000>;
> };
> indicator {
> - max-microamp = <17500>;
> + led-max-microamp = <17500>;
> };
> };
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-06 23:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-25 23:37 [PATCH] Fix documentation for adp1653 DT Pali Rohár
2015-12-26 18:34 ` Pavel Machek
2016-01-06 23:23 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox