From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753453AbbL0NHx (ORCPT ); Sun, 27 Dec 2015 08:07:53 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:33768 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621AbbL0NHv (ORCPT ); Sun, 27 Dec 2015 08:07:51 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Gabriele Mazzotta Subject: Re: [PATCH 0/2] Fixes for dell-wmi Date: Sun, 27 Dec 2015 14:07:47 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-71-generic; KDE/4.14.2; x86_64; ; ) Cc: Matthew Garrett , Darren Hart , =?utf-8?q?Micha=C5=82_K=C4=99pie=C5=84?= , Andy Lutomirski , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <1450991926-20937-1-git-send-email-pali.rohar@gmail.com> <567FE0CD.6080107@gmail.com> In-Reply-To: <567FE0CD.6080107@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2445909.bJln45jkVe"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201512271407.47844@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart2445909.bJln45jkVe Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 27 December 2015 13:59:57 Gabriele Mazzotta wrote: > On 24/12/2015 22:18, Pali Roh=C3=A1r wrote: > > This patch series adds check if Dell WMI descriptor structure is > > valid and fixes processing WMI events on devices with WMI > > interface version 0. > >=20 > > After testing, second patch is good candidate for backporting into > > stable kernels, but problem is that it cannot be used without > > first patch. So I let decision to other people. > >=20 > > Gabriele and Micha=C5=82, this patch series should fix processing events > > on yours Dell laptops (you have in DSDT defined version 0). Can > > you test it? >=20 > Hi, >=20 > I tested the patches and all the function keys work, but I can see > that there are some differences in the dmesg. >=20 > Here a before and after comparison. >=20 > The radio button seems to generate longer messages when compared to > the others. Hi! Thanks for testing. Can you please recompile driver with line=20 #define DEBUG at beginning of dell-wmi.c file and send dmesg output=20 again? I want to see processing buffer debug lines in dmesg. Here we=20 should see that after this patch series garbage will not be parsed. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart2445909.bJln45jkVe Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlZ/4qMACgkQi/DJPQPkQ1I0zwCcC0sMU3xKPPvEheDfGKM6VaWX oUcAoLAOONOCU5DuG0ng8fTwA79F/t00 =HCcx -----END PGP SIGNATURE----- --nextPart2445909.bJln45jkVe--