From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbbL1OsU (ORCPT ); Mon, 28 Dec 2015 09:48:20 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:34115 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbbL1OsR (ORCPT ); Mon, 28 Dec 2015 09:48:17 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Henrique de Moraes Holschuh Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Date: Mon, 28 Dec 2015 15:48:14 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-71-generic; KDE/4.14.2; x86_64; ; ) Cc: Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <20151227231417.GB8731@khazad-dum.debian.net> In-Reply-To: <20151227231417.GB8731@khazad-dum.debian.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart12101165.radMcZ7XEk"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201512281548.14411@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart12101165.radMcZ7XEk Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Monday 28 December 2015 00:14:17 Henrique de Moraes Holschuh wrote: > On Thu, 24 Dec 2015, Pali Roh=C3=A1r wrote: > > This patch adds support for controlling keyboard backlight via > > standard linux led class interface (::kbd_backlight). It uses ACPI > > HKEY device with MLCG and MLCS methods. > >=20 > > Signed-off-by: Pali Roh=C3=A1r > > Tested-by: Fabio D'Urso >=20 > It looks good at a first glance. But at init you might need to take > steps so that the current state is not changed. Did you test this? Tested. Modprobing driver does not change keyboard backlight level. > Also, is it working properly across suspend+resume? When doing resume from suspend or hibernate BIOS turning keyboard=20 backlight automatically off. But driver at any time report correct backlight level from sysfs node. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart12101165.radMcZ7XEk Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlaBS64ACgkQi/DJPQPkQ1LU9QCfVuqiOqBPwLqvYTpVG9LNcaiU hJwAnRpW/QtLrBFKOtX+qtk0gPqZ/oBk =okNf -----END PGP SIGNATURE----- --nextPart12101165.radMcZ7XEk--