public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Jeremiah Mahler <jmmahler@gmail.com>,
	linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>, Ingo Molnar <mingo@kernel.org>,
	Tejun Heo <tj@kernel.org>
Subject: Re: BUG: Bad rss-counter state mm:ffff8800c5a96000 idx:3 val:3894
Date: Tue, 29 Dec 2015 10:30:37 -0800	[thread overview]
Message-ID: <20151229103037.68d1643d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20151229162346.GB10321@dhcp22.suse.cz>

On Tue, 29 Dec 2015 17:23:47 +0100 Michal Hocko <mhocko@kernel.org> wrote:

> [CCing Andrew]
> 
> On Thu 24-12-15 09:12:53, Jeremiah Mahler wrote:
> > all,
> > 
> > I have started seeing a "Bad rss-counter" message in the logs with
> > the latest linux-next 20151222+.
> > 
> >   [  458.282192] BUG: Bad rss-counter state mm:ffff8800c5a96000 idx:3 val:3894
> 
> This is MM_SHMEMPAGES so an "unamapped" shmem memory. One possible
> reason might be an unitialized zap_details used from unmap_mapping_range
> during truncate introduced by "mm, oom: introduce oom reaper" from the
> mmotm tree. There is a fix for this which is still pending
> http://lkml.kernel.org/r/1450487091-7822-1-git-send-email-sasha.levin%40oracle.com

That won't be getting fixed until linux-next returns from holidays.

This:

--- a/mm/memory.c~mm-oom-introduce-oom-reaper-fix-5-fix
+++ a/mm/memory.c
@@ -2415,7 +2415,7 @@ static inline void unmap_mapping_range_t
 void unmap_mapping_range(struct address_space *mapping,
 		loff_t const holebegin, loff_t const holelen, int even_cows)
 {
-	struct zap_details details;
+	struct zap_details details = { };
 	pgoff_t hba = holebegin >> PAGE_SHIFT;
 	pgoff_t hlen = (holelen + PAGE_SIZE - 1) >> PAGE_SHIFT;
 
_


  reply	other threads:[~2015-12-29 18:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-24 17:12 BUG: Bad rss-counter state mm:ffff8800c5a96000 idx:3 val:3894 Jeremiah Mahler
2015-12-29 16:23 ` Michal Hocko
2015-12-29 18:30   ` Andrew Morton [this message]
2015-12-29 18:57     ` Jeremiah Mahler
2015-12-30 22:32     ` Stephen Rothwell
2016-01-04 21:22 ` Andrew Morton
2016-01-04 22:46   ` Kirill A. Shutemov
2016-01-05  1:41     ` Jeremiah Mahler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151229103037.68d1643d.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jmmahler@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mhocko@kernel.org \
    --cc=mingo@kernel.org \
    --cc=tj@kernel.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox