From: Andrew Morton <akpm@linux-foundation.org>
To: Gang He <ghe@suse.com>
Cc: mfasheh@suse.com, rgoldwyn@suse.de, linux-kernel@vger.kernel.org,
ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check
Date: Tue, 29 Dec 2015 13:38:44 -0800 [thread overview]
Message-ID: <20151229133844.b2758dbe21604e64acd50383@linux-foundation.org> (raw)
In-Reply-To: <1451027779-6849-2-git-send-email-ghe@suse.com>
On Fri, 25 Dec 2015 15:16:16 +0800 Gang He <ghe@suse.com> wrote:
> Export ocfs2_kset object from ocfs2_stackglue kernel module,
> then online file check code will create the related sysfiles
> under ocfs2_kset object.
>
> ...
>
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -629,7 +629,8 @@ static struct attribute_group ocfs2_attr_group = {
> .attrs = ocfs2_attrs,
> };
>
> -static struct kset *ocfs2_kset;
> +struct kset *ocfs2_kset;
> +EXPORT_SYMBOL_GPL(ocfs2_kset);
The EXPORT_SYMBOL is only needed if this symbol is to be referred to
from a different module. That isn't the case here - everything which
refers to ocfs2_kset is linked into ocfs2.ko, correct?
next prev parent reply other threads:[~2015-12-29 21:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-25 7:16 [PATCH v3 0/4] Add online file check feature Gang He
2015-12-25 7:16 ` [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check Gang He
2015-12-29 21:38 ` Andrew Morton [this message]
2015-12-30 6:13 ` Gang He
2016-01-13 23:02 ` Mark Fasheh
2016-01-13 23:07 ` Andrew Morton
2015-12-25 7:16 ` [PATCH v3 2/4] ocfs2: sysfile interfaces " Gang He
2016-01-13 23:35 ` Mark Fasheh
2016-01-14 3:13 ` Gang He
2015-12-25 7:16 ` [PATCH v3 3/4] ocfs2: create/remove sysfile " Gang He
2016-01-13 23:36 ` Mark Fasheh
2015-12-25 7:16 ` [PATCH v3 4/4] ocfs2: check/fix inode block " Gang He
2016-01-14 1:40 ` [Ocfs2-devel] " Mark Fasheh
2016-01-14 6:30 ` Gang He
2015-12-29 21:41 ` [PATCH v3 0/4] Add online file check feature Andrew Morton
2015-12-30 3:00 ` Gang He
2015-12-30 3:14 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151229133844.b2758dbe21604e64acd50383@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ghe@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox