From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "Ksenija Stanojević" <ksenija.stanojevic@gmail.com>
Cc: willy@meta-x.org, devel@driverdev.osuosl.org,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters
Date: Wed, 30 Dec 2015 17:02:03 +0530 [thread overview]
Message-ID: <20151230113203.GA30551@sudip-pc> (raw)
In-Reply-To: <CAL7P5j+gZ5AGvdwRbj+xBQzR3KvwXDXRrJDceuEfcWS8zyG+2g@mail.gmail.com>
On Wed, Dec 30, 2015 at 11:13:40AM +0100, Ksenija Stanojević wrote:
> On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
> >> Split comment in order to fit into 80 characters per line.
> >> Found by checkpatch.pl
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >> ---
> >
> > Instead of multiline maybe this is better:
> >
> > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> > index 79ac192..3525919 100644
> > --- a/drivers/staging/panel/panel.c
> > +++ b/drivers/staging/panel/panel.c
> > @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
> > lcd_send_serial(0x5F); /* R/W=W, RS=1 */
> > lcd_send_serial(' ' & 0x0F);
> > lcd_send_serial((' ' >> 4) & 0x0F);
> > - usleep_range(40, 100); /* the shortest data takes at least 40 us */
> > + /* the shortest data takes at least 40 us */
> > + usleep_range(40, 100);
> > }
> > spin_unlock_irq(&pprt_lock);
>
> It's already been done by Bijosh Thykkoottathil:
> https://lkml.org/lkml/2015/12/18/681
But I think not yet accepted by Greg. And his commit message doesnot
mention what coding style errors he has fixed. Usually Greg will not
accept them.
regards
sudip
next prev parent reply other threads:[~2015-12-30 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 11:15 [PATCH 0/2] Staging: panel: Fix checkpatch warnings Ksenija Stanojevic
2015-12-27 11:16 ` [PATCH 1/2] Staging: panel: Fix line over 80 characters Ksenija Stanojevic
2015-12-30 5:01 ` Sudip Mukherjee
2015-12-30 10:13 ` Ksenija Stanojević
2015-12-30 11:32 ` Sudip Mukherjee [this message]
2015-12-27 11:17 ` [PATCH 2/2] Staging: panel: Remove space Ksenija Stanojevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151230113203.GA30551@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ksenija.stanojevic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox