[PATCH 0/2] Staging: panel: Fix checkpatch warnings

[PATCH 0/2] Staging: panel: Fix checkpatch warnings

[Ksenija Stanojevic]

Fix checkpatch.pl warnings in panel.c

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>

Ksenija Stanojevic (2):
  Staging: panel: Fix line over 80 characters
  Staging: panel: Remove space

 drivers/staging/panel/panel.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

-- 
1.9.1

[PATCH 1/2] Staging: panel: Fix line over 80 characters

[Ksenija Stanojevic]

Split comment in order to fit into 80 characters per line.
Found by checkpatch.pl

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
 drivers/staging/panel/panel.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 79ac192..7171c5d 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -947,7 +947,9 @@ static void lcd_clear_fast_s(void)
 		lcd_send_serial(0x5F);	/* R/W=W, RS=1 */
 		lcd_send_serial(' ' & 0x0F);
 		lcd_send_serial((' ' >> 4) & 0x0F);
-		usleep_range(40, 100);	/* the shortest data takes at least 40 us */
+		usleep_range(40, 100);	/* the shortest data
+					 * takes at least 40 us
+					 */
 	}
 	spin_unlock_irq(&pprt_lock);
 
-- 
1.9.1

[PATCH 2/2] Staging: panel: Remove space

[Ksenija Stanojevic]

No space is necessary after a cast, therefore remove it.
Found by checkpatch.pl

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
 drivers/staging/panel/panel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 7171c5d..567b584 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1790,7 +1790,7 @@ static void phys_scan_contacts(void)
 	gndmask = PNL_PINPUT(r_str(pprt)) & scan_mask_i;
 
 	/* grounded inputs are signals 40-44 */
-	phys_read |= (pmask_t) gndmask << 40;
+	phys_read |= (pmask_t)gndmask << 40;
 
 	if (bitmask != gndmask) {
 		/*
@@ -1806,7 +1806,7 @@ static void phys_scan_contacts(void)
 
 			w_dtr(pprt, oldval & ~bitval);	/* enable this output */
 			bitmask = PNL_PINPUT(r_str(pprt)) & ~gndmask;
-			phys_read |= (pmask_t) bitmask << (5 * bit);
+			phys_read |= (pmask_t)bitmask << (5 * bit);
 		}
 		w_dtr(pprt, oldval);	/* disable all outputs */
 	}
-- 
1.9.1

Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

[Sudip Mukherjee]

On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
> Split comment in order to fit into 80 characters per line.
> Found by checkpatch.pl
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---

Instead of multiline maybe this is better:

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 79ac192..3525919 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
 		lcd_send_serial(0x5F);	/* R/W=W, RS=1 */
 		lcd_send_serial(' ' & 0x0F);
 		lcd_send_serial((' ' >> 4) & 0x0F);
-		usleep_range(40, 100);	/* the shortest data takes at least 40 us */
+		/* the shortest data takes at least 40 us */
+		usleep_range(40, 100);
 	}
 	spin_unlock_irq(&pprt_lock);


regards
sudip

Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

[Ksenija Stanojević]

On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
>> Split comment in order to fit into 80 characters per line.
>> Found by checkpatch.pl
>>
>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>> ---
>
> Instead of multiline maybe this is better:
>
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 79ac192..3525919 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
>                 lcd_send_serial(0x5F);  /* R/W=W, RS=1 */
>                 lcd_send_serial(' ' & 0x0F);
>                 lcd_send_serial((' ' >> 4) & 0x0F);
> -               usleep_range(40, 100);  /* the shortest data takes at least 40 us */
> +               /* the shortest data takes at least 40 us */
> +               usleep_range(40, 100);
>         }
>         spin_unlock_irq(&pprt_lock);

It's already been done by Bijosh Thykkoottathil:
https://lkml.org/lkml/2015/12/18/681

Regards,
Ksenija

Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

[Sudip Mukherjee]

On Wed, Dec 30, 2015 at 11:13:40AM +0100, Ksenija Stanojević wrote:
> On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
> >> Split comment in order to fit into 80 characters per line.
> >> Found by checkpatch.pl
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >> ---
> >
> > Instead of multiline maybe this is better:
> >
> > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> > index 79ac192..3525919 100644
> > --- a/drivers/staging/panel/panel.c
> > +++ b/drivers/staging/panel/panel.c
> > @@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
> >                 lcd_send_serial(0x5F);  /* R/W=W, RS=1 */
> >                 lcd_send_serial(' ' & 0x0F);
> >                 lcd_send_serial((' ' >> 4) & 0x0F);
> > -               usleep_range(40, 100);  /* the shortest data takes at least 40 us */
> > +               /* the shortest data takes at least 40 us */
> > +               usleep_range(40, 100);
> >         }
> >         spin_unlock_irq(&pprt_lock);
> 
> It's already been done by Bijosh Thykkoottathil:
> https://lkml.org/lkml/2015/12/18/681

But I think not yet accepted by Greg. And his commit message doesnot
mention what coding style errors he has fixed. Usually Greg will not
accept them.

regards
sudip