From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751446AbcAAF5P (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Jan 2016 00:57:15 -0500
Received: from mail-pf0-f171.google.com ([209.85.192.171]:34909 "EHLO
	mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751119AbcAAF5K convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Jan 2016 00:57:10 -0500
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To: Brian Norris <computersforpeace@gmail.com>,
        "Stephen Boyd" <sboyd@codeaurora.org>
From: Michael Turquette <mturquette@baylibre.com>
In-Reply-To: <1450290903-24470-1-git-send-email-computersforpeace@gmail.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Brian Norris" <computersforpeace@gmail.com>,
        "Jyri Sarha" <jsarha@ti.com>, "Sergej Sawazki" <ce3a@gmx.de>
References: <1450290511-14442-1-git-send-email-computersforpeace@gmail.com>
 <1450290903-24470-1-git-send-email-computersforpeace@gmail.com>
Message-ID: <20160101055708.21738.66909@quark.deferred.io>
User-Agent: alot/0.3.6
Subject: Re: [PATCH] clk: gpio: handle error codes for of_clk_get_parent_count()
Date: Thu, 31 Dec 2015 21:57:08 -0800
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quoting Brian Norris (2015-12-16 10:35:03)
> We might make bad memory allocations if we get (e.g.) -ENOSYS from
> of_clk_get_parent_count().
> 
> Noticed by Coverity.
> 
> Fixes: f66541ba02d5 ("clk: gpio: Get parent clk names in of_gpio_clk_setup()")
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Jyri Sarha <jsarha@ti.com>
> Cc: Sergej Sawazki <ce3a@gmx.de>
> Cc: Stephen Boyd <sboyd@codeaurora.org>

Thanks for the fix. Applied.

Regards,
Mike

> ---
> Sorry, I noticed Coverity was complaining about 1 more.
> 
>  drivers/clk/clk-gpio.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
> index c1baa89cbf91..1767b9e3ca93 100644
> --- a/drivers/clk/clk-gpio.c
> +++ b/drivers/clk/clk-gpio.c
> @@ -287,12 +287,14 @@ static void __init of_gpio_clk_setup(struct device_node *node,
>         const char **parent_names;
>         int i, num_parents;
>  
> +       num_parents = of_clk_get_parent_count(node);
> +       if (num_parents < 0)
> +               return;
> +
>         data = kzalloc(sizeof(*data), GFP_KERNEL);
>         if (!data)
>                 return;
>  
> -       num_parents = of_clk_get_parent_count(node);
> -
>         parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL);
>         if (!parent_names) {
>                 kfree(data);
> -- 
> 2.6.0.rc2.230.g3dd15c0
>