From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751669AbcABONj (ORCPT ); Sat, 2 Jan 2016 09:13:39 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:33863 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbcABONh (ORCPT ); Sat, 2 Jan 2016 09:13:37 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Tony Lindgren Subject: Nokia N900: twl4030-power different data in DTS and board code Date: Sat, 2 Jan 2016 15:13:32 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-71-generic; KDE/4.14.2; x86_64; ; ) Cc: Ivaylo Dimitrov , Pavel Machel , Sebastian Reichel , Nishanth Menon , Aaro Koskinen , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4928047.maPgc7PTdl"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201601021513.32814@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart4928047.maPgc7PTdl Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, now I'm looking at differences between legacy board code and DTS file for Nokia N900 and I see some inconsistency for twl4030-power driver. In board code are defined more twl4030 power scripts which override defaults defined in twl4030-power code. See: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/a= rm/mach-omap2/board-rx51-peripherals.c#n790 Next in DTS file is defined just "compatible" keyword, but no custom scripts, see: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/a= rm/boot/dts/omap3-n900.dts#n416 And the last in DTS file is defined line: compatible =3D "ti,twl4030-power-n900"=20 which is not in twl4030-power driver itself, see: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/driver= s/mfd/twl4030-power.c#n851 So all this stuff looks like some errors when board code was ported to DTS. Tony, can you look at this at all? =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart4928047.maPgc7PTdl Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlaH2wwACgkQi/DJPQPkQ1L2ggCbBhX/BuEzqRK1JBvOURsfEqjq OuoAn0N4UrJBuO/tXNPVybah79eiiC3o =dNbE -----END PGP SIGNATURE----- --nextPart4928047.maPgc7PTdl--