From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Pavel Machel <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
Nishanth Menon <nm@ti.com>, Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Nokia N900: twl4030-power different data in DTS and board code
Date: Sat, 2 Jan 2016 09:14:31 -0800 [thread overview]
Message-ID: <20160102171430.GC12622@atomide.com> (raw)
In-Reply-To: <201601021513.32814@pali>
* Pali Rohár <pali.rohar@gmail.com> [160102 06:14]:
> Hello,
>
> now I'm looking at differences between legacy board code and DTS file
> for Nokia N900 and I see some inconsistency for twl4030-power driver.
>
> In board code are defined more twl4030 power scripts which override
> defaults defined in twl4030-power code. See:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/mach-omap2/board-rx51-peripherals.c#n790
>
> Next in DTS file is defined just "compatible" keyword, but no custom
> scripts, see:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/omap3-n900.dts#n416
>
> And the last in DTS file is defined line:
>
> compatible = "ti,twl4030-power-n900"
>
> which is not in twl4030-power driver itself, see:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/mfd/twl4030-power.c#n851
>
> So all this stuff looks like some errors when board code was ported to
> DTS. Tony, can you look at this at all?
AFAIK it should work fine with the generic "ti,twl4030-power-idle-osc-off".
This means reboot works and regulators are cut off during off mode.
The n900 specific code was based on something before the TI generic values
were available I think. And the last time I looked at it I came to the
conclusion the n900 specific code is no better.
Or did I miss something? Are you seeing some issues with PM with dts based
code?
We can certainly add it to twl4030-power if it provides something that
the "ti,twl4030-power-idle-osc-off" does not.
Regards,
Tony
next prev parent reply other threads:[~2016-01-02 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 14:13 Nokia N900: twl4030-power different data in DTS and board code Pali Rohár
2016-01-02 17:14 ` Tony Lindgren [this message]
2016-01-02 21:39 ` Pali Rohár
2016-01-04 16:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160102171430.GC12622@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).