From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752079AbcABU7U (ORCPT ); Sat, 2 Jan 2016 15:59:20 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:35966 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbcABU7T (ORCPT ); Sat, 2 Jan 2016 15:59:19 -0500 Date: Sat, 2 Jan 2016 21:59:42 +0000 From: Hugo Camboulive To: Al Viro Cc: gregkh@linuxfoundation.org, chaehyun.lim@gmail.com, christian.gromm@microchip.com, andrey.shvetsov@k2l.de, sudipm.mukherjee@gmail.com, joe@perches.com, shraddha.6596@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: most: add __iomem for io_base and registers Message-ID: <20160102215942.GA3847@hugo-core> References: <1451766621-3047-1-git-send-email-hugo.camboulive@gmail.com> <20160102203322.GJ9938@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160102203322.GJ9938@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 02 Jan 2016 20:33:23 (+0000), Al Viro wrote: > On Sat, Jan 02, 2016 at 08:30:21PM +0000, Hugo Camboulive wrote: > > This removes a few Sparse warnings. > > > + g.dim2 = (struct dim2_regs __iomem *)dim_base_address; > > > -u8 dim_startup(void *dim_base_address, u32 mlb_clock); > > +u8 dim_startup(void __iomem *dim_base_address, u32 mlb_clock); > > Umm... Why not have it take struct dim2_regs __iomem * as argument, and > to hell with that cast? Oh, right. I wasn't sure if the original void* was there for a reason. I'll send a v2.