From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751293AbcACC5M (ORCPT ); Sat, 2 Jan 2016 21:57:12 -0500 Received: from mail-pf0-f176.google.com ([209.85.192.176]:34112 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbcACC5J (ORCPT ); Sat, 2 Jan 2016 21:57:09 -0500 Date: Sun, 3 Jan 2016 08:27:04 +0530 From: Niranjan Dighe To: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , Mike Rapoport , Jeremiah Mahler , James Simmons , Haneen Mohammed , Mike Shuey , Arnd Bergmann , Al Viro Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: lustre: Fix 'unexpected unlock' warning generated by sparse Message-ID: <20160103025704.GA31228@codebox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Added annotation '__must_hold' to function ksocknal_send_keepalive_locked which unlocks the lock ksocknal_data.ksnd_global_lock. As this lock is not acquired in the current function, sparse warns about context imbalance Signed-off-by: Niranjan Dighe --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c index 477b385..29525a0 100644 --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c @@ -2336,6 +2336,7 @@ ksocknal_flush_stale_txs(ksock_peer_t *peer) static int ksocknal_send_keepalive_locked(ksock_peer_t *peer) +__must_hold(&ksocknal_data.ksnd_global_lock) { ksock_sched_t *sched; ksock_conn_t *conn; -- 1.9.1