From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751429AbcACEuQ (ORCPT ); Sat, 2 Jan 2016 23:50:16 -0500 Received: from imap.thunk.org ([74.207.234.97]:33127 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840AbcACEuO (ORCPT ); Sat, 2 Jan 2016 23:50:14 -0500 Date: Sat, 2 Jan 2016 22:54:40 -0500 From: "Theodore Ts'o" To: Arnd Bergmann Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: disable retry logic in ext4_set_encrypted_filename Message-ID: <20160103035440.GR3248@thunk.org> Mail-Followup-To: Theodore Ts'o , Arnd Bergmann , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <3125077.SmBO9VTSER@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3125077.SmBO9VTSER@wuerfel> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 02, 2016 at 08:50:11PM +0100, Arnd Bergmann wrote: > gcc correctly warns that the ctx variable in ext4_set_encrypted_filename > has gone out of scope in ext4_set_encrypted_filename if we enter the > retry path and a 'goto' into the previous code block can not guarantee > to get the contents back: > > fs/ext4/namei.c: In function 'ext4_set_encrypted_filename': > fs/ext4/namei.c:4035:10: warning: 'ctx' may be used uninitialized in this function [-Wmaybe-uninitialized] > retval = ext4_xattr_set_handle(handle, inode, Sorry, this was a known bug that I fixed about a week ago, but I hadn't pushed out an update to the ext4 dev branch because I hadn't had a chance to finish testing the project quota changes. I've just pushed out an update. - Ted