linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu OTHACEHE <m.othacehe@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v6] USB: serial: add Moxa UPORT 11x0 driver
Date: Sun, 3 Jan 2016 15:22:00 +0100	[thread overview]
Message-ID: <20160103142200.GA15024@gmail.com> (raw)
In-Reply-To: <20151229122956.GB25531@localhost>

Hi Johan,

Thanks for merging !
About the follow ups, I have tested the driver on uport 1110 without double OPEN_PORT/START_PORT commands.
It is still working fine so, I guess it can be removed.

Plus, I sniffed the Windows USB driver for uport 1110 and the commands sent are : OPEN_PORT, SET_CONFIG, START_PORT, CLOSE_PORT.
The STOP_PORT command isn't used. I add it anyway to close callback and it doesn't modify driver's behaviour.

I will post a patch serie cleaning up control commands and adding a probe callback as you suggested.

Thanks,
Mathieu

      reply	other threads:[~2016-01-03 14:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 11:29 [PATCH v5] USB: serial: add Moxa UPORT 11x0 driver Mathieu OTHACEHE
2015-12-28 14:06 ` Johan Hovold
2015-12-28 14:39   ` One Thousand Gnomes
2015-12-28 15:32     ` Johan Hovold
2015-12-28 20:21       ` [PATCH v6] " Mathieu OTHACEHE
2015-12-29 12:29         ` Johan Hovold
2016-01-03 14:22           ` Mathieu OTHACEHE [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160103142200.GA15024@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).