From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751830AbcACOWO (ORCPT ); Sun, 3 Jan 2016 09:22:14 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:35840 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbcACOWL (ORCPT ); Sun, 3 Jan 2016 09:22:11 -0500 Date: Sun, 3 Jan 2016 15:22:00 +0100 From: Mathieu OTHACEHE To: Johan Hovold Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v6] USB: serial: add Moxa UPORT 11x0 driver Message-ID: <20160103142200.GA15024@gmail.com> References: <20151228153238.GB18146@localhost> <1451334085-23464-1-git-send-email-m.othacehe@gmail.com> <20151229122956.GB25531@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151229122956.GB25531@localhost> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, Thanks for merging ! About the follow ups, I have tested the driver on uport 1110 without double OPEN_PORT/START_PORT commands. It is still working fine so, I guess it can be removed. Plus, I sniffed the Windows USB driver for uport 1110 and the commands sent are : OPEN_PORT, SET_CONFIG, START_PORT, CLOSE_PORT. The STOP_PORT command isn't used. I add it anyway to close callback and it doesn't modify driver's behaviour. I will post a patch serie cleaning up control commands and adding a probe callback as you suggested. Thanks, Mathieu