The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: netdev@vger.kernel.org, Igal.Liberman@freescale.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] fsl/fman: allow modular build
Date: Mon, 04 Jan 2016 21:54:59 -0500 (EST)	[thread overview]
Message-ID: <20160104.215459.1264934689312091785.davem@davemloft.net> (raw)
In-Reply-To: <4109142.02mezJXbJM@wuerfel>

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 01 Jan 2016 14:55:24 +0100

> ARM allmodconfig fails because of the addition of the FMAN driver:
> 
> drivers/built-in.o: In function `dtsec_restart_autoneg':
> binder.c:(.text+0x173328): undefined reference to `mdiobus_read'
> binder.c:(.text+0x173348): undefined reference to `mdiobus_write'
> drivers/built-in.o: In function `dtsec_config':
> binder.c:(.text+0x173d24): undefined reference to `of_phy_find_device'
> drivers/built-in.o: In function `init_phy':
> binder.c:(.text+0x1763b0): undefined reference to `of_phy_connect'
> drivers/built-in.o: In function `stop':
> binder.c:(.text+0x176014): undefined reference to `phy_stop'
> drivers/built-in.o: In function `start':
> binder.c:(.text+0x176078): undefined reference to `phy_start'
> 
> The reason is that the driver uses PHYLIB, but that is a loadable
> module here, and fman itself is built-in.
> 
> This patch makes it possible to configure fman as a module as well
> so we don't change the status of PHYLIB in an allmodconfig kernel,
> and it adds a 'select PHYLIB' statement to ensure that phylib is
> always built-in when fman is.
> 
> The driver uses "builtin_platform_driver(fman_driver);", which means
> it cannot be unloaded, but it's still possible to have it as a loadable
> module that gets loaded once and never removed.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5adae51a64b8 ("fsl/fman: Add FMan MURAM support")

Applied, sorry I didn't catch this but nobody else was even attempting
to review that huge patch series so I did the best that I could... :-/

      reply	other threads:[~2016-01-05  2:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01 13:55 [PATCH] fsl/fman: allow modular build Arnd Bergmann
2016-01-05  2:54 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160104.215459.1264934689312091785.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Igal.Liberman@freescale.com \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox