From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936AbcADHKR (ORCPT ); Mon, 4 Jan 2016 02:10:17 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37665 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752798AbcADHKP (ORCPT ); Mon, 4 Jan 2016 02:10:15 -0500 Date: Mon, 4 Jan 2016 08:10:12 +0100 From: Daniel Vetter To: Julia Lawall Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Daniel Vetter Subject: Re: [PATCH] drm/dp/mst: constify drm_dp_mst_topology_cbs structures Message-ID: <20160104071012.GD8076@phenom.ffwll.local> Mail-Followup-To: Julia Lawall , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Daniel Vetter References: <1451510430-11149-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451510430-11149-1-git-send-email-Julia.Lawall@lip6.fr> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 30, 2015 at 10:20:30PM +0100, Julia Lawall wrote: > The drm_dp_mst_topology_cbs structures are never modified, so declare them > as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied to drm-misc, thanks. -Daniel > > --- > drivers/gpu/drm/i915/intel_dp_mst.c | 2 +- > drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +- > include/drm/drm_dp_mst_helper.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h > index 74b5888..b37b859 100644 > --- a/include/drm/drm_dp_mst_helper.h > +++ b/include/drm/drm_dp_mst_helper.h > @@ -421,7 +421,7 @@ struct drm_dp_payload { > struct drm_dp_mst_topology_mgr { > > struct device *dev; > - struct drm_dp_mst_topology_cbs *cbs; > + const struct drm_dp_mst_topology_cbs *cbs; > int max_dpcd_transaction_bytes; > struct drm_dp_aux *aux; /* auxch for this topology mgr to use */ > int max_payloads; > diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c > index 94323f5..8a02225 100644 > --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c > +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c > @@ -329,7 +329,7 @@ static void radeon_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr) > drm_kms_helper_hotplug_event(dev); > } > > -struct drm_dp_mst_topology_cbs mst_cbs = { > +const struct drm_dp_mst_topology_cbs mst_cbs = { > .add_connector = radeon_dp_add_mst_connector, > .register_connector = radeon_dp_register_mst_connector, > .destroy_connector = radeon_dp_destroy_mst_connector, > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c > index e2f515d..fa0dabf 100644 > --- a/drivers/gpu/drm/i915/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/intel_dp_mst.c > @@ -534,7 +534,7 @@ static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr) > drm_kms_helper_hotplug_event(dev); > } > > -static struct drm_dp_mst_topology_cbs mst_cbs = { > +static const struct drm_dp_mst_topology_cbs mst_cbs = { > .add_connector = intel_dp_add_mst_connector, > .register_connector = intel_dp_register_mst_connector, > .destroy_connector = intel_dp_destroy_mst_connector, > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch