From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753069AbcADIR4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jan 2016 03:17:56 -0500
Received: from mail-wm0-f49.google.com ([74.125.82.49]:33128 "EHLO
	mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751505AbcADIRx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jan 2016 03:17:53 -0500
Date: Mon, 4 Jan 2016 09:17:50 +0100
From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jammy Zhou <Jammy.Zhou@amd.com>, David Airlie <airlied@linux.ie>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Alex Deucher <alexander.deucher@amd.com>,
        David Zhang <david1.zhang@amd.com>,
        Eric Huang <JinHuiEric.Huang@amd.com>,
        Christian =?utf-8?B?S8O2bmln?= <christian.koenig@amd.com>
Subject: Re: [PATCH] drm: powerplay: use div64_s64 instead of do_div
Message-ID: <20160104081750.GA23797@ulmo>
References: <5249276.tkZ1gbxakA@wuerfel>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF"
Content-Disposition: inline
In-Reply-To: <5249276.tkZ1gbxakA@wuerfel>
User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--3MwIy2ne0vdjdPXF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 01, 2016 at 02:07:41PM +0100, Arnd Bergmann wrote:
> The newly added code for Fiji creates a correct compiler warning
> about invalid use of the do_div macro:
>=20
> In file included from powerplay/hwmgr/ppatomctrl.c:31:0:
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/ppevvmath.h: In function 'f=
Divide':
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/ppevvmath.h:382:89: warning=
: comparison of distinct pointer types lacks a cast
>      do_div(longlongX, longlongY); /*Q(32,32) divided by Q(16,16) =3D Q(1=
6,16) Back to original format */
>=20
> do_div() divides an unsigned 64-bit number by an unsigned 32-bit number.
> The code instead wants to divide two signed 64-bit numbers, which is done
> using the div64_s64 function.
>=20
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 770911a3cfbb ("drm/amd/powerplay: add/update headers for Fiji SMU =
and DPM")
> ---
> Found on ARM allmodconfig on yesterday's linux-next=20

Reviewed-by: Thierry Reding <treding@nvidia.com>

--3MwIy2ne0vdjdPXF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJWiiquAAoJEN0jrNd/PrOh6iQP+wR/NMmhoD+fph2S1Bdc2H5D
AOFOMZ3Vff6d0lOfq4fbId7P1FO0aJ1gbwG4qRDe0up6eGm95OG26H0xtcJjrU/z
tR7kqs8y2ZgVf/uvxZ3nlTp2DZwCYlrKMNhfdsi7Y8Oa/hwXeNsH0KAt8XGX0UiT
5qjCCVkcC9452JaJ0mhL8K73QTO+GFOhlidJBfkKEKju+v8nrb8gx9Lukuc5n7Et
o/eYnPkmyfLehuL4T/u2/yFcsBAjGTrWxyDb+hwVn4JEP8z6GLwKdoUPJbGBEwZL
Q+195G2Iyrwysypf1YXLCc+JLr67e0dg8Xn4hIgaBzd8/fvs9TtfsjdkTgFPN8g3
mzL0tWEuGEbMAV7FilI4lwHs3amNDZZ7vkZ+O070cS4n+BU790afGt5bbFOeajuQ
Rk9H6iBUmipRDYDhvkdVkNorMIMZwcfw6SoNG8BrY9C3i5Xs9kvb/Xq6MZjU6NT9
z3XHD/yLTpHTl87juPToMKAEKusDpNnV9lmEF3AZj4AirnzQHweOigvt8SUSrrK1
KTbejrgLBivmb820cAOuZ1gYBLYiqCoVwoyhYs29Kijq3w35S9TCjrSPvjIleOXF
pmhQ55UB+SyrDizOYDV81cLuN5In0jDdwviZn9EnjJcJ6DIoNQbGqc76C/joa4iI
lwcGXTsEJ4e9qt3rVrcL
=+Smh
-----END PGP SIGNATURE-----

--3MwIy2ne0vdjdPXF--