From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbcADIYU (ORCPT ); Mon, 4 Jan 2016 03:24:20 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38063 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbcADIYS (ORCPT ); Mon, 4 Jan 2016 03:24:18 -0500 Date: Mon, 4 Jan 2016 09:24:16 +0100 From: Thierry Reding To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, David Airlie , Liviu Dudau , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Message-ID: <20160104082416.GB23797@ulmo> References: <4194408.X82ccDjh5X@wuerfel> <5213510.IMdSbsXdoQ@wuerfel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tsOsTdHNUZQcU9Ye" Content-Disposition: inline In-Reply-To: <5213510.IMdSbsXdoQ@wuerfel> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tsOsTdHNUZQcU9Ye Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 01, 2016 at 11:04:07PM +0100, Arnd Bergmann wrote: > CONFIG_DRM_HDLCD is a tristate option that depends on the boolean > CONFIG_DRM_ARM, which in turn depends on the tristate CONFIG_DRM. > The effect of this is that a configuration with CONFIG_DRM=3Dm > and CONFIG_DRM_HDLCD=3Dy can be chosen, but won't link because the > DRM core symbols are not reachable from builtin code: >=20 > drivers/built-in.o: In function `hdlcd_drm_unbind': > drivers/gpu/drm/arm/hdlcd_drv.c:445: undefined reference to `drm_fbdev_cm= a_fini' > drivers/gpu/drm/arm/hdlcd_drv.c:448: undefined reference to `drm_kms_help= er_poll_fini' > drivers/gpu/drm/arm/hdlcd_drv.c:450: undefined reference to `drm_vblank_c= leanup' > drivers/gpu/drm/arm/hdlcd_drv.c:452: undefined reference to `drm_irq_unin= stall' > drivers/gpu/drm/arm/hdlcd_drv.c:460: undefined reference to `drm_mode_con= fig_cleanup' > drivers/gpu/drm/arm/hdlcd_drv.c:461: undefined reference to `drm_dev_unre= gister' > drivers/gpu/drm/arm/hdlcd_drv.c:462: undefined reference to `drm_dev_unre= f' > ... >=20 > This adds another dependency on CONFIG_DRM to enforce that DRM_HDLCD > cannot be builtin if DRM is not. Ugh... wouldn't it be much simpler to get rid of DRM_ARM? It seems like a completely superfluous option to me. I don't think we've ever had the equivalent of "vendor" Kconfig options in DRM, and I don't see why we'd need to start now. If ARM was going to add another driver it can simply have a separate Kconfig entry. There should be no need to select the vendor option first. Thierry --tsOsTdHNUZQcU9Ye Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWiiwvAAoJEN0jrNd/PrOhKMkP/Raf5rrJuovZXN6w/xz4qwCn 7MyBs7rsffQUyQjomWtp3f7Wjsk7ae0Lj+tbZBt2gzg30Qw3XK2WboRAk377Xp26 GTk0o5JMO04YQOCry1DuLiKyq+ghy8kIS4pPNLRT+vGNjjoC9xNkhZsh+mkY5lHs Ra+aMhvESY62DFnteCxxKZR2CyxPIKIUSOSqcGaM12uZJemscw74siv8SwGT0U41 gAY5dyFDTyINA+ZCCKJEuXebI2U3L5xU0BwVh5Q9+pdvuWcPQYsgxc57E0V43jhW AadO3GpiIObFW82AJUKZFkas4KqnSGbP+HCIQ5v9KbDO+1AxtyHKblNDxHoWoQQj 6YKyyJ8N/NwgowMqa8mFX00+LBOErn3Mzi8nrLe7joM2D039OgbP9f2wVlVoAinm 20WZW06nWx6XlGu3y/aqv1skGNHG4m0prJxnFDQLMhpZx2wbfySyXmHdjWk8Ygf8 EwM0VRsPR3B7yIH/mcN5R9qz7LXSC/SrcJ6uH8RKQL4J8UfnM9rkr+1Trqy4dbyF JHPtS5AmrzAmcRMK48xJFC7h05PfyZYG8EFTcbqBe8cw+/ls+CTaB2o4OFuvht/W ae+Tr1wFaL8trb6p1HYQZ9d3oSxjTeSUW4lydEELyxx7cFup6N3Y7/Twz7XnDHlK 717eIhZcO1Fg8n7oAoXh =UiH6 -----END PGP SIGNATURE----- --tsOsTdHNUZQcU9Ye--