From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752969AbcADILi (ORCPT ); Mon, 4 Jan 2016 03:11:38 -0500 Received: from down.free-electrons.com ([37.187.137.238]:34435 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751104AbcADILe (ORCPT ); Mon, 4 Jan 2016 03:11:34 -0500 Date: Mon, 4 Jan 2016 09:11:31 +0100 From: Boris Brezillon To: Milo Kim Cc: , , , , , , Subject: Re: [PATCH 01/19] irqchip: atmel-aic: fix wrong bit operation for IRQ priority Message-ID: <20160104091131.214e1542@bbrezillon> In-Reply-To: <1451881723-2478-2-git-send-email-milo.kim@ti.com> References: <1451881723-2478-1-git-send-email-milo.kim@ti.com> <1451881723-2478-2-git-send-email-milo.kim@ti.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Milo, On Mon, 4 Jan 2016 13:28:25 +0900 Milo Kim wrote: > Atmel AIC has common structure for SMR (Source Mode Register). > > bit[6:5] Interrupt source type > bit[2:0] Priority level > Other bits are unused. > > To update new priority value, bit[2:0] should be cleared first and then > new priority level can be written. However, aic_common_set_priority() > helper clears source type bits instead of priority bits. > This patch fixes wrong mask bit operation. > > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: Marc Zyngier > Cc: Alexandre Belloni > Cc: Boris BREZILLON > Cc: Ludovic Desroches > Cc: Nicolas Ferre > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim Acked-by: Boris Brezillon Can you also add Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") Cc: stable@vger.kernel.org #v3.17+ Thanks, Boris > --- > drivers/irqchip/irq-atmel-aic-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-atmel-aic-common.c b/drivers/irqchip/irq-atmel-aic-common.c > index b12a5d5..37199b9 100644 > --- a/drivers/irqchip/irq-atmel-aic-common.c > +++ b/drivers/irqchip/irq-atmel-aic-common.c > @@ -86,7 +86,7 @@ int aic_common_set_priority(int priority, unsigned *val) > priority > AT91_AIC_IRQ_MAX_PRIORITY) > return -EINVAL; > > - *val &= AT91_AIC_PRIOR; > + *val &= ~AT91_AIC_PRIOR; > *val |= priority; > > return 0; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com