From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753039AbcADIQz (ORCPT ); Mon, 4 Jan 2016 03:16:55 -0500 Received: from down.free-electrons.com ([37.187.137.238]:34476 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751340AbcADIQv (ORCPT ); Mon, 4 Jan 2016 03:16:51 -0500 Date: Mon, 4 Jan 2016 09:16:49 +0100 From: Boris Brezillon To: Milo Kim Cc: , , , , , , Subject: Re: [PATCH 02/19] irqchip: atmel-aic: clean up RTC interrupt code Message-ID: <20160104091649.339060d7@bbrezillon> In-Reply-To: <1451881723-2478-3-git-send-email-milo.kim@ti.com> References: <1451881723-2478-1-git-send-email-milo.kim@ti.com> <1451881723-2478-3-git-send-email-milo.kim@ti.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Milo, On Mon, 4 Jan 2016 13:28:26 +0900 Milo Kim wrote: > Atmel AIC disables RTC interrupt on initialization. However, the controller > doesn't need to do it. There are two reasons. > > * RTC driver disables interrupts on _probe() > RTC_IDR is set to 0x1f which means all RTC interrupts are disabled. > (drivers/rtc/rtc-at91rm9200.c) > at91_rtc_write_idr(AT91_RTC_ACKUPD | AT91_RTC_ALARM | > AT91_RTC_SECEV | AT91_RTC_TIMEV | > AT91_RTC_CALEV); > > * All RTC interrupts are disabled by default. > If we try to read RTC_IMR(interrup mask status), then read value is 0 > by default. It means all RTC interrupts are disabled by default. > We can also check the default status in the datasheet. Please note that > all devices have same RTC registers. > AT91RM9200 > AT91SAM9N12 > AT91SAM9X5 > AT91SAM9G45 > AT91SAM9RL > SAMA5D3 > SAMA5D4 > > So, aic_common_rtc_irq_fixup() helper can be removed. Please read b2f579b58e93 ("irqchip: atmel-aic: Add irq fixup infrastructure") and 3d61467f9bab ("irqchip: atmel-aic: Implement RTC irq fixup") messages before assuming you can simply remove these functions. There's a good reason behind this irq fixup infrastructure, and you're blindly removing those functions without asking why we were doing that. Best Regards, Boris > > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: Marc Zyngier > Cc: Alexandre Belloni > Cc: Boris BREZILLON > Cc: Ludovic Desroches > Cc: Nicolas Ferre > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim > --- > drivers/irqchip/irq-atmel-aic-common.c | 28 ---------------------------- > drivers/irqchip/irq-atmel-aic-common.h | 2 -- > drivers/irqchip/irq-atmel-aic.c | 9 --------- > drivers/irqchip/irq-atmel-aic5.c | 13 ------------- > 4 files changed, 52 deletions(-) > > diff --git a/drivers/irqchip/irq-atmel-aic-common.c b/drivers/irqchip/irq-atmel-aic-common.c > index 37199b9..f8261be 100644 > --- a/drivers/irqchip/irq-atmel-aic-common.c > +++ b/drivers/irqchip/irq-atmel-aic-common.c > @@ -139,34 +139,6 @@ static void __init aic_common_ext_irq_of_init(struct irq_domain *domain) > } > } > > -#define AT91_RTC_IDR 0x24 > -#define AT91_RTC_IMR 0x28 > -#define AT91_RTC_IRQ_MASK 0x1f > - > -void __init aic_common_rtc_irq_fixup(struct device_node *root) > -{ > - struct device_node *np; > - void __iomem *regs; > - > - np = of_find_compatible_node(root, NULL, "atmel,at91rm9200-rtc"); > - if (!np) > - np = of_find_compatible_node(root, NULL, > - "atmel,at91sam9x5-rtc"); > - > - if (!np) > - return; > - > - regs = of_iomap(np, 0); > - of_node_put(np); > - > - if (!regs) > - return; > - > - writel(AT91_RTC_IRQ_MASK, regs + AT91_RTC_IDR); > - > - iounmap(regs); > -} > - > #define AT91_RTT_MR 0x00 /* Real-time Mode Register */ > #define AT91_RTT_ALMIEN (1 << 16) /* Alarm Interrupt Enable */ > #define AT91_RTT_RTTINCIEN (1 << 17) /* Real Time Timer Increment Interrupt Enable */ > diff --git a/drivers/irqchip/irq-atmel-aic-common.h b/drivers/irqchip/irq-atmel-aic-common.h > index 603f0a9..9027f15 100644 > --- a/drivers/irqchip/irq-atmel-aic-common.h > +++ b/drivers/irqchip/irq-atmel-aic-common.h > @@ -32,8 +32,6 @@ struct irq_domain *__init aic_common_of_init(struct device_node *node, > const struct irq_domain_ops *ops, > const char *name, int nirqs); > > -void __init aic_common_rtc_irq_fixup(struct device_node *root); > - > void __init aic_common_rtt_irq_fixup(struct device_node *root); > > void __init aic_common_irq_fixup(const struct of_device_id *matches); > diff --git a/drivers/irqchip/irq-atmel-aic.c b/drivers/irqchip/irq-atmel-aic.c > index 8a0c7f2..4c60224 100644 > --- a/drivers/irqchip/irq-atmel-aic.c > +++ b/drivers/irqchip/irq-atmel-aic.c > @@ -209,11 +209,6 @@ static const struct irq_domain_ops aic_irq_ops = { > .xlate = aic_irq_domain_xlate, > }; > > -static void __init at91rm9200_aic_irq_fixup(struct device_node *root) > -{ > - aic_common_rtc_irq_fixup(root); > -} > - > static void __init at91sam9260_aic_irq_fixup(struct device_node *root) > { > aic_common_rtt_irq_fixup(root); > @@ -221,16 +216,12 @@ static void __init at91sam9260_aic_irq_fixup(struct device_node *root) > > static void __init at91sam9g45_aic_irq_fixup(struct device_node *root) > { > - aic_common_rtc_irq_fixup(root); > aic_common_rtt_irq_fixup(root); > } > > static const struct of_device_id aic_irq_fixups[] __initconst = { > - { .compatible = "atmel,at91rm9200", .data = at91rm9200_aic_irq_fixup }, > { .compatible = "atmel,at91sam9g45", .data = at91sam9g45_aic_irq_fixup }, > - { .compatible = "atmel,at91sam9n12", .data = at91rm9200_aic_irq_fixup }, > { .compatible = "atmel,at91sam9rl", .data = at91sam9g45_aic_irq_fixup }, > - { .compatible = "atmel,at91sam9x5", .data = at91rm9200_aic_irq_fixup }, > { .compatible = "atmel,at91sam9260", .data = at91sam9260_aic_irq_fixup }, > { .compatible = "atmel,at91sam9261", .data = at91sam9260_aic_irq_fixup }, > { .compatible = "atmel,at91sam9263", .data = at91sam9260_aic_irq_fixup }, > diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c > index 62bb840..8b8f5e2 100644 > --- a/drivers/irqchip/irq-atmel-aic5.c > +++ b/drivers/irqchip/irq-atmel-aic5.c > @@ -285,17 +285,6 @@ static const struct irq_domain_ops aic5_irq_ops = { > .xlate = aic5_irq_domain_xlate, > }; > > -static void __init sama5d3_aic_irq_fixup(struct device_node *root) > -{ > - aic_common_rtc_irq_fixup(root); > -} > - > -static const struct of_device_id aic5_irq_fixups[] __initconst = { > - { .compatible = "atmel,sama5d3", .data = sama5d3_aic_irq_fixup }, > - { .compatible = "atmel,sama5d4", .data = sama5d3_aic_irq_fixup }, > - { /* sentinel */ }, > -}; > - > static int __init aic5_of_init(struct device_node *node, > struct device_node *parent, > int nirqs) > @@ -316,8 +305,6 @@ static int __init aic5_of_init(struct device_node *node, > if (IS_ERR(domain)) > return PTR_ERR(domain); > > - aic_common_irq_fixup(aic5_irq_fixups); > - > aic5_domain = domain; > nchips = aic5_domain->revmap_size / 32; > for (i = 0; i < nchips; i++) { -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com