From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512AbcADPbe (ORCPT ); Mon, 4 Jan 2016 10:31:34 -0500 Received: from smtprelay0071.hostedemail.com ([216.40.44.71]:33239 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751450AbcADPbb (ORCPT ); Mon, 4 Jan 2016 10:31:31 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:2693:2892:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3873:3874:4362:4605:5007:6261:7875:7903:8603:9040:10004:10400:10848:10967:11026:11232:11658:11914:12043:12114:12296:12438:12517:12519:12555:12663:12679:12740:13069:13071:13138:13231:13255:13311:13357:14096:14097:14659:21060:21080:30030:30054:30070:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:7,LUA_SUMMARY:none X-HE-Tag: thumb67_471c51629b929 X-Filterd-Recvd-Size: 2620 Date: Mon, 4 Jan 2016 10:31:27 -0500 From: Steven Rostedt To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Frederic Weisbecker , Andi Kleen , Wang Nan Subject: Re: [PATCH v4.1 03/13] tools lib traceevent: Factor out and export print_event_field[s] Message-ID: <20160104103127.786a2b8e@gandalf.local.home> In-Reply-To: <1450876121-22494-1-git-send-email-namhyung@kernel.org> References: <1450804030-29193-4-git-send-email-namhyung@kernel.org> <1450876121-22494-1-git-send-email-namhyung@kernel.org> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Dec 2015 22:08:41 +0900 Namhyung Kim wrote: > The print_event_field() and print_event_fields() are to print basic > information of a given field or event without the print format. They'll > be used by dynamic sort keys later. Hi Namhyung, > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h > index 6fc83c7edbe9..600c73277a6f 100644 > --- a/tools/lib/traceevent/event-parse.h > +++ b/tools/lib/traceevent/event-parse.h > @@ -705,6 +705,10 @@ struct cmdline *pevent_data_pid_from_comm(struct pevent *pevent, const char *com > struct cmdline *next); > int pevent_cmdline_pid(struct pevent *pevent, struct cmdline *cmdline); > > +void print_event_field(struct trace_seq *s, void *data, > + struct format_field *field); > +void print_event_fields(struct trace_seq *s, void *data, > + int size __maybe_unused, struct event_format *event); I'm fine with the patch, but can you change the function names to be less generic, as this will now be part of a library (that I hope will become something supplied by distros soon). Like: pevent_print_field(); and pevent_print_fields(); Thanks! -- Steve > void pevent_event_info(struct trace_seq *s, struct event_format *event, > struct pevent_record *record); > int pevent_strerror(struct pevent *pevent, enum pevent_errno errnum,