From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753449AbcADL3y (ORCPT ); Mon, 4 Jan 2016 06:29:54 -0500 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:57238 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbcADL3w (ORCPT ); Mon, 4 Jan 2016 06:29:52 -0500 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: kernel-janitors@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Mon, 4 Jan 2016 12:29:48 +0100 From: Heiko Carstens To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, Martin Schwidefsky , Ursula Braun , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online() Message-ID: <20160104112948.GD4179@osiris> References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F198.4040109@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5688F198.4040109@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16010411-0021-0000-0000-000008772B9E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 03, 2016 at 11:02:00AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 10:48:05 +0100 > > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. > > Signed-off-by: Markus Elfring > --- > drivers/s390/net/qeth_core_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c > index 7871537..54fde2e 100644 > --- a/drivers/s390/net/qeth_core_main.c > +++ b/drivers/s390/net/qeth_core_main.c > @@ -5637,7 +5637,7 @@ static void qeth_core_remove_device(struct ccwgroup_device *gdev) > static int qeth_core_set_online(struct ccwgroup_device *gdev) > { > struct qeth_card *card = dev_get_drvdata(&gdev->dev); > - int rc = 0; > + int rc; > int def_discipline; You can generate hundreds of patches like this one. There are even plenty more opportunities within this same file. I don't think we need this. If at all then change all occurrences within a file at once, but that is Ursula's call.