From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753892AbcADM06 (ORCPT ); Mon, 4 Jan 2016 07:26:58 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:27657 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753859AbcADM0m (ORCPT ); Mon, 4 Jan 2016 07:26:42 -0500 Date: Mon, 4 Jan 2016 15:26:32 +0300 From: Dan Carpenter To: Samuel Thibault , William Hubbs , Chris Brannon , Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: speakup: Fix getting port information Message-ID: <20160104122631.GK5284@mwanda> References: <20160102232529.GC2860@var.home> <15457.1451779836@ccs.covici.com> <20160103005620.GM2860@var.home> <20160104122249.GJ5284@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160104122249.GJ5284@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 03:22:49PM +0300, Dan Carpenter wrote: > On Sun, Jan 03, 2016 at 01:56:20AM +0100, Samuel Thibault wrote: > > covici@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > > I had a patch which also worked, but yours may be better -- I enclose it > > > here for your information. > > > > Well, it's not up to serialio.h to include things for serialio.c. That > > however makes me realize that the culprit is actually > > f79b0d9 (which actually doesn't make much sense since linux/serial.h is > > getting included a couple of lines above...). > Btw, the patch title of that patch f79b0d9c223a ('staging: speakup: Fixed warning instead of ') describes exactly everything about the patch. So including the title really does help save time for everyone. regards, dan carpenter