From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751510AbcADOzv (ORCPT ); Mon, 4 Jan 2016 09:55:51 -0500 Received: from m50-134.163.com ([123.125.50.134]:53553 "EHLO m50-134.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbcADOzt (ORCPT ); Mon, 4 Jan 2016 09:55:49 -0500 Date: Mon, 4 Jan 2016 22:54:22 +0800 From: Geliang Tang To: Vinod Koul Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Geliang Tang Subject: Re: [PATCH 2/4] ALSA: hdac: drop unused dev_to_hdac macro Message-ID: <20160104145421.GA16267@bogon> References: <00c81b79d57196a8a72ce9c4a0e8ca5d3ec2eba7.1451312334.git.geliangtang@163.com> <20160104082347.GG2940@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160104082347.GG2940@localhost> User-Agent: Mutt/1.5.24 (2015-08-30) X-CM-TRANSID: DtGowEDp30qih4pW6rg3AA--.14644S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ArWrWFyxCrWDuFyrZry7KFg_yoW8XrWrpr 4UGFyfKFWqgrsI9a1v9r409Fy5t3W8GF1rX3yj9w1fCF1Yvr1fAFyrtrW7ua48ZrW5uFWf XFy8ta45Jay3CFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRQTmgUUUUU= X-Originating-IP: [116.77.129.183] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiowXlmVUL3xfMGQAAsZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 01:53:47PM +0530, Vinod Koul wrote: > On Mon, Dec 28, 2015 at 10:47:11PM +0800, Geliang Tang wrote: > > dev_to_hdac is not used anymore so drop it. > > No harm in keeping this for now as the systems using these will be coming > up and more users will be upstreamed... > Thanks for your review. Sorry that I didn't make myself clear in the commit log. What I droped is a repetitive macro. dev_to_hdac() in hdac_ext_bus.c and dev_to_hdac_dev() in hdaudio.h are the same: include/sound/hdaudio.h: #define dev_to_hdac_dev(_dev) container_of(_dev, struct hdac_device, dev) sound/hda/ext/hdac_ext_bus.c: #define dev_to_hdac(dev) (container_of((dev), \ struct hdac_device, dev)) Users should use dev_to_hdac_dev() in hdaudio.h, not dev_to_hdac(). -Geliang > > > > Signed-off-by: Geliang Tang > > --- > > sound/hda/ext/hdac_ext_bus.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c > > index 2433f7c..58f6b98 100644 > > --- a/sound/hda/ext/hdac_ext_bus.c > > +++ b/sound/hda/ext/hdac_ext_bus.c > > @@ -197,8 +197,6 @@ void snd_hdac_ext_bus_device_remove(struct hdac_ext_bus *ebus) > > } > > } > > EXPORT_SYMBOL_GPL(snd_hdac_ext_bus_device_remove); > > -#define dev_to_hdac(dev) (container_of((dev), \ > > - struct hdac_device, dev)) > > > > static inline struct hdac_ext_driver *get_edrv(struct device *dev) > > { > > -- > > 2.5.0