From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752128AbcADPQk (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jan 2016 10:16:40 -0500
Received: from mail.kernel.org ([198.145.29.136]:52950 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751880AbcADPQg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jan 2016 10:16:36 -0500
Date: Mon, 4 Jan 2016 12:16:26 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 06/13] perf tools: Try to show pretty printed output for
 dynamic sort keys
Message-ID: <20160104151626.GB5462@kernel.org>
References: <1450804030-29193-1-git-send-email-namhyung@kernel.org>
 <1450804030-29193-7-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450804030-29193-7-git-send-email-namhyung@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Dec 23, 2015 at 02:07:03AM +0900, Namhyung Kim escreveu:
> Each tracepoint event has format string for print to improve
> readability.  Try to parse the output and match the field name.  If it
> finds one, use that for the result.  If not, fallbacks to the original
> output.
> 
> For example, sort on kmem:kmalloc.gfp_flags looks like below:
> (Note: libtraceevent plugins are not installed on my system.  They might
> affect the output below)
> 
> Before:
>   # Overhead  Command   gfp_flags
>   # ........  .......  ..........
>   #
>       99.89%  perf          32848
>        0.06%  sleep           208
>        0.03%  perf          32976
>        0.01%  perf            208
> 
> After:
>   # Overhead  Command            gfp_flags
>   # ........  .......  ...................
>   #
>       99.89%  perf       GFP_NOFS|GFP_ZERO
>        0.06%  sleep             GFP_KERNEL
>        0.03%  perf     GFP_KERNEL|GFP_ZERO
>        0.01%  perf              GFP_KERNEL
> 
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/util/hist.c |   1 +
>  tools/perf/util/sort.c | 105 ++++++++++++++++++++++++++++++++++++++++++++++---
>  tools/perf/util/sort.h |   1 +
>  3 files changed, 102 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index c0c92a3daa69..ef1a4a5cc610 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -978,6 +978,7 @@ void hist_entry__delete(struct hist_entry *he)
>  	if (he->srcfile && he->srcfile[0])
>  		free(he->srcfile);
>  	free_callchain(he->callchain);
> +	free(he->trace_output);
>  	free(he);
>  }

This clashed with an updated patch earlier in this this patchkit
("[PATCH v4.1 02/13] perf hist: Save raw_data/size for tracepoint events"),
fixing it.

- Arnaldo